Bugzilla – Bug 5547
Home menu order needs tweaking
Last modified: 2007-09-25 08:45:57 UTC
The order of items on the home menu on Jive needs tweaking. Should be: Now Playing My Music Internet Radio Music On Demand Favorites Extras Settings Choose Player (when appropriate) Turn <playername> Off (when appropriate)
this has turned out to be far more non-trivial than it looks. Items on the main menu come from two sources, SS and Jive, and there is no current facility for weighting the items when the sources are merged. + = created by Jive SimpleMenu * = sent from SS and created by SlimBrowser proposed order: +Now Playing *My Music *Internet Radio *Music On Demand *Favorites +Extras +Settings +Choose Player (when appropriate) *Turn <playername> Off (when appropriate) To make this really work, there would need to be an optional weight parameter sent over from SS Jive to order menu items, and SlimBrowser would need to have weighting built into its _merge method (taking into account weight from both SS items and Jive items), similar to what SimpleMenu does internally for sorting. FWIW, the ordering that SimpleMenu does by weight within the Jive-created items is also lost when SlimBrowser does the menu merge. I'll have to come back to this later. Spent a few hours on it and really got nowhere. My Lua-fu isn't quite up to task for this.
Another way to look at it is to have SS choose the order by sending down the full list, with special URLs or some other identifier to hint the browser into inserting its own functions, rather than have the browser mix the two together with some sorting algorithm.
fixed in Jive r554, SS r13264 added optional weight parameter to any item for sorting by weight. If no weight, item goes into menu in order of its index in the table.