Bug 5546 – Use player name on Settings Info item

Bug 5546 - Use player name on Settings Info item

Summary:

Use player name on Settings Info item

Status:	RESOLVED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	UI
Version:	unspecified
Platform:	Macintosh Other

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-09-22 21:32 UTC by Blackketter Dean
Modified:	2007-10-30 09:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Blackketter Dean 2007-09-22 21:32:09 UTC

Instead of "Player Info" it should be "Kitchen Info" or whatever the player name is.

Also see bug 4481

Comment 1 KDF 2007-09-23 17:57:15 UTC

This affects both the menu item and the title on the info menu.

Index: ../../trunk/Slim/Plugin/Jive/Plugin.pm
===================================================================
--- ../../trunk/Slim/Plugin/Jive/Plugin.pm      (revision 13215)
+++ ../../trunk/Slim/Plugin/Jive/Plugin.pm      (working copy)
@@ -653,7 +653,7 @@
 
        # information, always display
        push @menu, {
-               text      => Slim::Utils::Strings::string('INFORMATION_MENU_PLAYER'),
+               text      => $client->name()." ".Slim::Utils::Strings::string('INFORMATION'),
                offset    => 0,
                count     => 1,
                textArea =>

Comment 2 Ben Klaas 2007-09-24 13:10:39 UTC

fixed in r13239

FWIW, I'm trying not to cobble strings together on the fly, as different languages have different rules for word ordering. Instead I'm using %s in the strings.txt file and using sprintf() to construct the string.