Bugzilla – Bug 5541
Favorites has redundant menu placing
Last modified: 2007-10-30 09:37:02 UTC
On Jive, there is a top level menu for Favorites, but it also exists under My Music. both the new Default skin and Player UI do not have favorites under My Music, but at the top level only. It would seem to be consistent to remove the Favorites from the My Music Menu in the Jive Plugin. Index: /usr/local/slimserver/trunk/Slim/Plugin/Jive/Plugin.pm =================================================================== --- /usr/local/slimserver/trunk/Slim/Plugin/Jive/Plugin.pm (revision 13202) +++ /usr/local/slimserver/trunk/Slim/Plugin/Jive/Plugin.pm (working copy) @@ -177,17 +177,6 @@ }, }, { - text => Slim::Utils::Strings::string('FAVORITES'), - actions => { - go => { - cmd => ['favorites', 'items'], - params => { - menu => 'favorites', - }, - }, - }, - }, - { text => Slim::Utils::Strings::string('BROWSE_MUSIC_FOLDER'), actions => { go => {
slight change, the patch needs to have the count as well as array change. (asking for trouble, but ok) Index: /usr/local/slimserver/trunk/Slim/Plugin/Jive/Plugin.pm =================================================================== --- /usr/local/slimserver/trunk/Slim/Plugin/Jive/Plugin.pm (revision 13202) +++ /usr/local/slimserver/trunk/Slim/Plugin/Jive/Plugin.pm (working copy) @@ -111,7 +111,7 @@ my @menu = ( { text => Slim::Utils::Strings::string('MY_MUSIC'), - count => 9, + count => 8, offset => 0, item_loop => [ { @@ -177,17 +177,6 @@ }, }, { - text => Slim::Utils::Strings::string('FAVORITES'), - actions => { - go => { - cmd => ['favorites', 'items'], - params => { - menu => 'favorites', - }, - }, - }, - }, - { text => Slim::Utils::Strings::string('BROWSE_MUSIC_FOLDER'), actions => { go => {
Assigned to Richard for his consideration.
Passing the buck to Dean...
Yes, favorites is top level only.
fixed in SC Jive module at change 13970