Bugzilla – Bug 5485
song info page cosmetic issues
Last modified: 2007-10-08 07:39:29 UTC
A couple of things I noticed on the song info page . The title in the grey area should just be the song title, not "SongInfo" or "Song Info for <songname>" The location (and I suspect other items that were long enough) should wrap on the left side to align with the beginning of the text, not all the way on the left portion. The text to the right of the p;lay and add buttons should be centered vertically with the buttons. See attached screenshot for reference.
Created attachment 2136 [details] reference screen shot
Songinfo is still work in progress (I didn't even remember I already had checked it in). It's proved to be harder to implement than I first thought. One issue I've encountered (besides the fact that it should share the code with other skins - if possible) is the usage for xmlbrowser, which can be radio stations, songs (podcasts) or text only (RSS), each with or without artwork. Especially the RSS case is giving me a hard time, as it just doesn't make sense to have this layout with text only. All in all I fear I won't be able to make it look the way we want with CSS only. This means not only a comeback of the tables, but breaking inheritance with existing skins, too. I haven't found a solution yet to reliably wrap long text withing the right "column" only. There are styles to do this. But guess what - "some" browsers either don't know them at all or have an all different idea of how to implement it. Expect some further changes early next week.
> The location (and I suspect other items that were long enough) should wrap on > the left side to align with the beginning of the text, not all the way on the > left portion. Should this read "should wrap on the right side"?
Change 13024 - consider these issues fixed. As long as you don't use the "leading" browser. I really didn't believe all the complaints about IE before I started this work. Now I do. IE7 is breaking styles which have been working for FF, Safari, Opera _and_ IE4-IE6! Dean - leave this bug open if you consider the current IE hacks not good enough. But there's more important stuff to be done before I'll come back to this page. I've spent way too much time on it.
Please reopen if needed.