Bug 5444 - Random Mix status doesn't update in non-continuous mode
: Random Mix status doesn't update in non-continuous mode
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugin
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-12 09:24 UTC by KDF
Modified: 2008-12-18 11:12 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2007-09-12 09:24:56 UTC
If you start a random mix that isn't continuously adding, then the %stopcommands are never allowed to clear the $miXinfo{type} and the player ui and web will always show the status as currently playing a mix.  


problem code at line 740:
if (!defined $client || !defined $mixInfo{$client->masterOrSelf->id}->{'type'} || !$prefs->get('continuous')) {
    return;
}

quick fix is to only set the type when mode is continuous (line 511)
		if ($continuousMode) {
			$mixInfo{$client->masterOrSelf->id}->{'type'} = $type;
		}

Not sure what other problems this might introduce, however.  More complicated is to track the type and state until one of the stop commands are encountered, or for static mode we wipe the status after the static list is ended (for non-repeat play).
Comment 1 Chris Owens 2007-09-12 15:39:32 UTC
I'm not sure who I could rope in that might have some opinion on your quick fix, KDF.  I'll target it for 7.0, though.
Comment 2 KDF 2007-09-13 14:23:15 UTC
fixed at change 13006 for trunk (v7.0a1 only)
please reopen if there are any problems.
Comment 3 Chris Owens 2008-03-07 09:04:54 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.