Bug 5436 - Web Interface fails when Digital Input Plugin is disabled
: Web Interface fails when Digital Input Plugin is disabled
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Spies Steven
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-10 07:24 UTC by rmgmailbox-sqbox
Modified: 2012-02-27 17:33 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
check whether the digital input plugin is disabled (631 bytes, patch)
2007-09-10 07:53 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rmgmailbox-sqbox 2007-09-10 07:24:34 UTC
With the The Digital Input plugin disabled, the following occurs:

With a player connected, when trying to connect to http://serveraddress:9000/ using any of the templates, the page will not load and the following warning line appears on the cmd line:
'Slim::Networking::Select::select (237) Error: Select task failed: Can't locate object method "webPages" via package "Slim::Plugin::DigitalInput::Plugin" at /<C:\Program Files\SlimServer\server\slim.exe>Slim/Web/Pages/Home.pm line 111.'

Web interface works fine without a player connected.

See this thread: http://forums.slimdevices.com/showthread.php?t=38272
Comment 1 Michael Herger 2007-09-10 07:53:19 UTC
Created attachment 2134 [details]
check whether the digital input plugin is disabled

I can't reproduce it (in fact, I can't disable the plugin...), but does this patch fix the issue?
Comment 2 rmgmailbox-sqbox 2007-09-11 01:53:09 UTC
Downloaded latest build 12972 - tested - no change. Is the patch included yet?
Comment 3 Michael Herger 2007-09-11 06:03:31 UTC
No, I wanted it to be tested before checking it in. As I can't reproduce right now, it's hard to test for me.
Comment 4 Chris Owens 2007-09-11 10:01:14 UTC
Steven, could you work with the original reporter to try to get this reproduced so we can accurately test michael's fix?
Comment 5 Michael Herger 2007-09-16 23:13:28 UTC
Change 13023 - I checked that change in. Please test.
Comment 6 rmgmailbox-sqbox 2007-09-17 02:15:20 UTC
Michael. Replaced Home.pm with new version (13023) and tested with DigitalInput Plugin disabled and enabled.  Result was same as before, error "Slim::Networking::Select::select (237) Error: Select task failed: Can't locate object method "webPages" via package "Slim::Plugin::DigitalInput::Plugin" at /<C:\Program Files\SlimServer\server\slim.exe>Slim/Web/Pages/Home.pm line 111." when Digital Input disabled.

Just to verify, modified Home.pm reads:

	if ($client && Slim::Utils::PluginManager->isEnabled('Plugin::DigitalInput::Plugin')) {

		Slim::Plugin::DigitalInput::Plugin->webPages($client->hasDigitalIn);
	}

Comment 7 Michael Herger 2007-09-17 02:19:40 UTC
You can't just replace a .pm file with the Windows executable. Please reinstall the latest nightly build to test it or install ActivePerl to run slimserver.pl from the command line.

The error you're still seeing is due to the fact that you're still running the old executable.
Comment 8 rmgmailbox-sqbox 2007-09-17 02:53:42 UTC
Yeah oops, OK Michael.  Installed latest nightly and the fix works fine.

Thanks
Comment 9 James Richardson 2012-02-27 17:33:10 UTC
Closing resolved bugs - if you feel this bug still exists please first re-test
with the latest SW/FW version.  If you are able to reproduce then feel free to
reopen and attach new logs / steps to reproduce.