Bug 539 - No display updates on doublesize track change
: No display updates on doublesize track change
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 5.x or older
: PC Other
: P2 normal (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-08 08:53 UTC by Jason Holtzapple
Modified: 2011-03-16 04:40 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
killanimation on new song (671 bytes, patch)
2004-09-09 01:42 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Holtzapple 2004-09-08 08:53:46 UTC
2004-09-08 CVS, SLIMP3, doublesize text mode - on track advance the display of
the track information is never updated on the SLIMP3. Regular size seems to work
fine. Toggling between sizes correctly updates doublesize until the next track
advance.
Comment 1 KDF 2004-09-09 01:38:43 UTC
Source.pm used to have this in openSong():
# We are starting a new song, lets kill any animation so we see the correct new
song.
foreach my $everyclient ($client, Slim::Player::Sync::syncedWith($client)) { 
  $everyclient->update();
}

Without this, there is nothing that breaks the animateScrollDouble loop, and the
$text11 & $text22 used for the animated lines. Its been there in several forms,
but removed totally in Source.pm v1.106.  comments are not clear as to why those
specific lines are removed.  putting them back, however, performs the needed
update. 
Comment 2 KDF 2004-09-09 01:42:10 UTC
Created attachment 128 [details]
killanimation on new song

as noted above, a $client->update was removed in Source.pm 1.106, all that's
needed is killAnimation to break the animation loops when a song changes.  the
screensaver takes care of an update if needed.
Comment 3 KDF 2004-09-09 01:59:35 UTC
in fact, I think this affects small text as well without this patch.
song info alternates from current, then snaps into the old song for the
animation which remains unkilled with old info.
Comment 4 Chris Owens 2006-06-16 14:40:32 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.
Comment 5 Chris Owens 2008-12-18 11:51:41 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.