Bug 5387 - Screensaver should exit on pause/stop
: Screensaver should exit on pause/stop
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Screensavers
: unspecified
: Macintosh Other
: P2 normal (vote)
: 7.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-05 07:43 UTC by Blackketter Dean
Modified: 2008-05-15 12:59 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2007-09-05 07:43:27 UTC
If you pause/stop Squeezebox while a Jive  is  in the Now Playing screensaver the screensaver should notice and exit (or give an opportunity for the stopped screensaver to kick in.
Comment 1 Richard Titmuss 2007-10-05 13:42:48 UTC
The Player object needs refactoring to notify applets when the player changes state. At the moment it only notifies the slimbrowser.

Ben may be doing that refactoring while working on Now Playing. Once that's done feel free to pass this back to me Ben, and I'll fix the screensaver.
Comment 2 Ben Klaas 2007-12-03 15:09:28 UTC

*** This bug has been marked as a duplicate of 6265 ***
Comment 3 Ben Klaas 2007-12-31 07:17:21 UTC
this particular issue now works as specified. closing.
Comment 4 Ben Klaas 2008-01-10 11:11:19 UTC
Actually, we don't do this at the screensaver level.

There is now a player notification when the mode changes, which can be used from any applet with a jnt subscription and a notify_playerModeChange method

Richard, you asked me to push it your way if that happened, so I will :)
Feel free to push it back my way if you want though, pretty sure I could figure the fix out quickly.

I think we want any screensaver to exit when the mode changes, not just NowPlaying. Also, we would want the screensaver to exit when the mode changes from any mode to any other mode

typical use example--

queue a few songs on jive, put it back in cradle
WhenPlaying screensaver kicks in
playlist ends, mode changes to "stopped"
WhenPlaying screensaver exits, timer starts
WhenStopped screensaver kicks in
Another playlist is queued up through webUI and started
WhenStopped screensaver exits, timer starts
WhenPlaying screensaver kicks in


that sound right?
Comment 5 Richard Titmuss 2008-01-11 14:50:03 UTC
Fixed in r1410. The now playing screensaver does not update the mode correctly. Back to Ben.
Comment 6 Richard Titmuss 2008-01-11 16:33:36 UTC
This seems to be working on, but it has a problem when show briefly appears. I
have a fix for this, but not sure it is the correct approach. I'll sleep on it.
Comment 7 Richard Titmuss 2008-01-14 03:50:42 UTC
Fixed popup behavior in r1426 and r1429. This bug is now totally fixed.
Comment 8 James Richardson 2008-05-15 12:59:20 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html