Bugzilla – Bug 5316
pressing PLAY on artist search results popup with wrong text
Last modified: 2009-09-08 09:21:32 UTC
When I search for artists and press play on a found artist, the popup appeared only for some of the albums. Repeatable on my system. Also, the popup showed the title of the song, it should have shown the name of the artist (i.e. the same as what's selected). This may be related to the above problem.
Adrain, do you have any ideas about this one?
At present it will show the track title rather than name of artist, not sure about it not showing though - it should show as long as there are tracks returned by the search command in playlistcontrolCommand. Is it repeatable by specific artists? If so could you run with --debug player.display=INFO and see if there is a showBriefly called by the server at: Slim::Display::Display::showBriefly (257) caller Slim::Control::Commands::playlistcontrolCommand (1688) As for the name given - at present it is just returning the title of track[0] found by the playlist play command, this makes it generic for all play commands. It could be easily extended to return different text based on the the playlistcommand request - i.e. artists or genere etc. I assume this is wanted from the comment below?
Re the text that is shown. If we are playing an album or track this fits with showing the album name or track title. However when playing an artist, genre or year, do we want to show the artwork for the first track or no artwork?
Ok, this is really two bugs. I'll try to reproduce the missing popup bug, and rename this one about the contents of the popup. The contents of the popup should match what is selected when played. So if it's an album, then the album art and album title should be displayed. If it's an artist, then the artist name should be displayed. We may have artist photos available sometime in the future, and would show those, but that's not ready yet.
Dean - please try SS change 13394. This should send the correct text to jive, but I've left the layout on jive to include an icon as it did not look as good just showing raw text. So at present it displays an albumart for album, song and artist [first album being played]. For other cases it displays the ? icon. Could we have some icons for "Play" and "Add" to show in these cases?
Hm, the idea here is that it should show in the popup the same content that you selected to play. So if it's an artist name without artwork, then it should be the same: Now Playing <Artist name> If we get artist images (post release) and those are in the artist list, then we should include that in the popup. Make sense?
We can definately make the popup work without artwork, I was just suggesting that a common layout with icon on the left and text on the right for all now playing popups looked better than some having icons and some not. I can change the artist/genre/year ones to not have artwork if this is desired, but we may want something more than just two lines of text with the second in bold? NB the content is currently produced on the server as in many cases we want to show different text from the label which existed on jive, so its not quite as simple as just showing what was selected in the menu when play was pressed as the server doesn't know this.
I think that making the popup consistent with the current view is more important than the popup being consistent in every view. Alas, I understand that it's hard to get the server to send back the same text that's being displayed. Is there a way to make that information come from the device instead?
I think it is currently showing the correct text? This is not exactly the same text as jive was previously showing but as in the case where there are three lines of text on the screen it extends it to four lines and makes it harder to decide which line to make bold. However it is context specific and so I the text is a good compromise at present? So I hope we are only debating whether the layout always includes an icon on the left with text on the right, or whether there icon should be dropped if ablum art is not available. [my original idea being that the icon could be one for the action if there is no relavent album art - so one for play and one for add] I can change it so only album and song which give an icon - but will need to be later this week.
Hey Dean - I got chance to look at this. Could you try SC change 13780 with Jive change 689. This should only show the artwork for album and song cases. I've added a new style with the middle line in bold for the other cases which does not include artwork. I think this is what you are looking for?
Dean - Any feedback on the current operation - I had hoped it was what you were looking for?
Sorry, haven't looked at this yet. Will do tomorrow.
God, sorry for the long delay on this. Artist and Album search and play works great. Song search shows only song titles and when you play a song, you don't see the album artwork. I'd expect the song search to return a list of songs as they would appear in the playlist (with artwork and artist and album information.) I'll file a separate bug for this.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.