Bugzilla – Bug 5296
MUSICBRAINZ_SORTNAME - not supported but in code?
Last modified: 2007-10-22 16:01:49 UTC
SS doesn't seem to support MUSICBRAINZ_SORTNAME (only ARTISTSORT as far as I can tell - I'm pretty sure a response from support confirmed this some time ago). If that is the case, I don't understand why it is referenced in FLAC.pm: my %tagMapping = ( 'TRACKNUMBER' => 'TRACKNUM', 'DISCNUMBER' => 'DISC', 'URL' => 'URLTAG', 'musicbrainz_sortname' => 'ARTISTSORT', 'MUSICBRAINZ_ALBUMARTISTID' => 'MUSICBRAINZ_ALBUMARTIST_ID', 'MUSICBRAINZ_ALBUMID' => 'MUSICBRAINZ_ALBUM_ID', 'MUSICBRAINZ_ALBUMSTATUS' => 'MUSICBRAINZ_ALBUM_STATUS', 'MUSICBRAINZ_ALBUMTYPE' => 'MUSICBRAINZ_ALBUM_TYPE', 'MUSICBRAINZ_ARTISTID' => 'MUSICBRAINZ_ARTIST_ID', 'MUSICBRAINZ_SORTNAME' => 'MUSICBRAINZ_SORTNAME', 'MUSICBRAINZ_TRACKID' => 'MUSICBRAINZ_ID', 'MUSICBRAINZ_TRMID' => 'MUSICBRAINZ_TRM_ID', My Perl isn't good enough to work out what is going on here. It looks pretty weird to me - MUSICBRAINZ_SORTNAME being mapped to itself, and musicbrainz_sortname being mapped to ARTISTSORT (why just do this for the lowercase version?). I'm on the latest (6.5.4 Linux) version of SS, but I believe this situation hasn't changed for some time. What I'd really like (and I'm sure I'm not alone) is for SS to support MUSICBRAINZ_SORTNAME. If that's not possible, maybe the above code needs tidying up? Cheers, Richard
the lowercase mappign was added at change 2900 by Michael. Michael, do you recall why? The rest of the MusicBrainz stuff came in at change 4306 from Dan, based on a patch provided by a user. The original intent was simply to collect the metadata for the purposes of using it in something like SlimScrobbler which can record usage based on musicbrainz_id. Technically, it is supported as collected metadata, just not as a sorting mechanism. I'm not sure I like the idea of mangling the ARTISTSORT field with potentially multiple sources. It's already enough of a nightmare with what is supported currently, and with what users end up having in their metadata.
(In reply to comment #1) > the lowercase mappign was added at change 2900 by Michael. Michael, do you > recall why? I'm sorry I can't help here. That's another Michael (michael at fallenangels dot com if I remember right). I never touched much in that area.
So it sounds like perhaps this should be converted to an enhancement request that we support sorting by MUSICBRAINZ_SORTNAME? And we will of course take KDF's comments into account.
(In reply to comment #3) > So it sounds like perhaps this should be converted to an enhancement request > that we support sorting by MUSICBRAINZ_SORTNAME? And we will of course take > KDF's comments into account. Well I'd obviously be very pleased if this could be done, but I understand KDF's comments re. adding confusion to the metadata side of things. I guess MUSICBRAINZ_SORTNAME should only be used if ARTISTSORT is empty.
Created attachment 2221 [details] Proposed patch to take MusicBrainz artist sort order into account The attached patch works for me. I looked quite hard and couldn't see what the lowercase 'musicbrainz_sortname' was for, and the mapping of 'MUSICBRAINZ_SORTNAME' back to itself just seemed plain wrong. Could those affected test it?
This is currently categorised as an enhancement - is that really the case? It looks like a defect to me as it appears as though the code in there was expected to work but doesn't do what it's supposed to. Also, it's marked as affecting PCs only (it affects all platforms), and Fedora only (it affects all operating systems). It would be nice to get this fixed in SqueezeCenter 7.
I applied this patch as change 13714 as well as adding it for MP3 and Ogg. MP3 uses a different tag for this: "MUSICBRAINZ ALBUM ARTIST SORTNAME".
See Bug 5764.
From what I can tell according to the MusicBrainz tag spec at http://musicbrainz.org/doc/MusicBrainzTag shouldn't 'XSOP' or 'TSOP' be mapped to 'ARTISTSORT' not 'TXXX MusicBrainz Album Artist Sortname'?
You're right, I removed the album artist sort mapping for MP3.
Looks good to me. From what I can tell both MusicBrainz Sortname and MusicBrainz Album Artist mapping has been added to SqueezeCenter. Only MusicBrainz Album Artist Sortname is missing since SqueezeCenter does not currently support AlbumArtistSort and Bug #4584 covers that.