Bug 5282 - home button shouldn't work during initial setup?
: home button shouldn't work during initial setup?
Status: RESOLVED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P2 normal (vote)
: MP
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-08-17 10:26 UTC by Blackketter Dean
Modified: 2007-11-10 20:09 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2007-08-17 10:26:32 UTC
the user should be forced to get connected first.
Comment 1 Richard Titmuss 2007-08-20 04:39:25 UTC
this will be fixed as a side effect of changing the home menu code.
Comment 2 Richard Titmuss 2007-08-25 07:42:34 UTC
To fix this the SetupWelcome applet needs to install (and then remove) a HOME button handler that does nothing. However I find this 'feature' useful at the moment for debugging, so lets fix this later.
Comment 3 Ben Klaas 2007-09-24 07:55:01 UTC
whaddya think Richard, is it time to put in the fix for this one, or do you want to wait a bit longer?
Comment 4 Fred 2007-10-03 04:01:11 UTC
I don't think "fixing" this is a good idea. I mean there shall exist a way to interrupt the setup stuff and display the home menu (from which you can access all kinds of useful functions like SD upgrade). Maybe the home button is not the right button for this trigger (some newbies may press it by mistake and "get lost"), but the *capability* it provides shall remain IMHO.

If Jive must have geek appeal, it should enable convenient tinkering. Having to enter my 32 letter WPA key just so that I can access the "update from SD" menu option is a pain. The fact Richard's finds the function useful is proof in the pudding.
Comment 5 Blackketter Dean 2007-10-03 07:26:26 UTC
The risk here is that a new user will accidentally press the home button and escape the setup process.  Requiring the device to be set up once (i.e. connected to a network) isn't an unreasonable requirement.  

An undocumented and hard to accidentally hit escape sequence (press and hold the back arrow to escape to a disconnected home menu, as I proposed elsewhere) would be a good alternative.
Comment 6 Dan Evans 2007-10-26 12:22:06 UTC
(copied from bug 5457)

Support will definitely need some way to escape the setup process.  Two reasons I can think for this off the top of my head:

1. In case I want to do a Factory Reset somewhere in the middle of the setup process. (a customer is stuck trying to enter their WEP key and it will not connect to their router.)

2. I need a customer to check which Firmware they have installed.  (they cannot get it connected to their network.)

Therefore, we need some sort of back door to the Settings menu.  

Pressing HOME during setup actually works fine, with one exception:  We need a "Return to Setup" menu option instead of "Choose Player".  

Requiring HOME be held for a few seconds would also be reasonable.  Or, holding LEFT for 5 seconds like Squeezebox 2 & 3 work, instead of HOME.

Thoughts?
Comment 7 Ben Klaas 2007-10-26 12:38:03 UTC
I like this option:

We need a "Return to Setup" menu option instead of "Choose Player".

will poke around with this and see if I can get it to work.
Comment 8 Blackketter Dean 2007-10-26 13:49:43 UTC
I don't mind the "return to setup" option if setup hasn't been completed, but the home button should definitely be disabled and use press and hold the <- arrow or Home to get Home in any situation.
Comment 9 Chris Owens 2007-10-30 09:33:53 UTC
Dean suggests we have holding down the left-arrow be the 'escape from whatever menu you are in'
Comment 10 Ben Klaas 2007-11-10 18:49:58 UTC
r866 disables home button during setup, but still allows press-hold back key to do the same thing (press-hold back key should have identical behavior to hitting home throughout Jive now)

I still need to add a "Return to setup" menu item in situations where setup wasn't completed. I may get that done yet tonight.
Comment 11 Ben Klaas 2007-11-10 20:09:56 UTC
fixed in r867

Add RETURN_TO_SETUP menu item to JiveMain
Remove RETURN_TO_SETUP when SetupWelcome is completed
Add methods to SimpleMenu for removing menu items by their text value