Bug 5209 – Compilation column remains as "NULL" with a compilation album.

Bug 5209 - Compilation column remains as "NULL" with a compilation album.

Summary:

Compilation column remains as "NULL" with a compilation album.

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Database
Version:	7.0
Platform:	PC Windows (legacy)

Importance:	P2 enhancement (vote)
Target Milestone:	Future
Assigned To:	Squeezebox QA Team email alias

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-08-01 10:23 UTC by Wallace Lai
Modified:	2009-09-10 08:51 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Wallace Lai 2007-08-01 10:23:52 UTC

Steps to Reproduce:
1.  Create two flac files.
2.  Use Mp3tag to edit the tags.
3.  Make the name of the album for the two tracks the same.
4.  Make the names of artists of the album different.
5.  Make the year of one track 2007.  The other one, 2006.
6.  Check the SlimServer database with SQLyog.
7.  Go to the album table.
8.  Notice the compilation value for the said album is "NULL".

Comment 1 Chris Owens 2007-08-02 09:48:17 UTC

The compilation field is populated by a compilation tag in the file, not assumed or calculated by slimserver.

Comment 2 Wallace Lai 2007-08-02 10:46:19 UTC

Based on Chris' comment, closing this bug.

Comment 3 Jim McAtee 2007-08-02 12:56:29 UTC

This is a great bug report, but it's only the tip of the iceberg.  Severity should be 'major' and priority P1.

(In reply to comment #1)
> The compilation field is populated by a compilation tag in the file, not
> assumed or calculated by slimserver. 

That's not correct.  SlimServer uses several means to determine if an album is a compilation, the COMPILATION tag being just one.  If an album is not found to be a compilation, then logically it should be consider NOT a compilation.  There is no third state.  Is it supposed to mean "unknown" or "maybe"?

NULL values are used far too much in the SlimServer database, in violation of widely recommended best practices.  They're a freaking nightmare to work with.

Comment 4 Chris Owens 2007-08-02 16:02:21 UTC

It sounds like grist for some kind of Slimserver coding practices document.

Comment 5 Blackketter Dean 2007-12-29 06:02:20 UTC

Is this an end-user visible issue?  Or just internal to the DB?

Comment 6 James Richardson 2009-09-10 08:51:19 UTC

I am unable to reproduce this with SqueezeCenter or SqueezeBox Server