Bug 5188 - SlimServer should report more accurate bitrate for Ogg files
: SlimServer should report more accurate bitrate for Ogg files
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: All All
: P2 enhancement (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-26 11:28 UTC by Keith Briscoe
Modified: 2008-12-18 11:12 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Briscoe 2007-07-26 11:28:41 UTC
This is very much a minor wishlist item, but it may be easy to implement.  Currently, SlimServer reports the bitrate of VBR files as the nominal bitrate, which may or may not be the actual bitrate of the file.  Some simple math on the server side ([audio data size]/[track length]) could be used to calculate the actual average bitrate of the file, which some users may find somewhat more informative.
Comment 1 Jim McAtee 2007-07-26 14:37:33 UTC
Are you talking about the information shown on the songinfo page?  I was under the impression that SlimServer does show the average bitrate.  What is it that you're calling 'nonimal' bitrate?
Comment 2 Keith Briscoe 2007-07-27 10:44:44 UTC
Yes, sorry.  I'm referring to the songinfo page.  All Vorbis -Q5 files show as 160kbps, and all Vorbis -Q6 files show as 192kbps, regardless of the actual average bitrate.

Perhaps Vorbis is the only format impacted?  Nominal bitrate does seem to be a Vorbis-specific concept.  Can you confirm other VBR formats show correctly?  If so, I can alter the title to indicate it's Vorbis only.  Vorbis has no CBR mode so the nominal bitrate is a really useless piece of data.

Comment 3 Keith Briscoe 2007-07-27 10:49:26 UTC
Er, this also applies to the track data screen accessible from the remote by going right from the current song.
Comment 4 Jim McAtee 2007-07-27 11:00:57 UTC
I don't know about all formats, but VBR mp3s do show average bitrate.  Flac files, which of course are lossless rather than lossy VBR, even show the average bitrate.  Both appear to use the simple formula you suggest of audio-data-size-in-kbits/track-length-in-seconds.
Comment 5 Keith Briscoe 2007-07-27 13:48:06 UTC
Changed title to reflect actual problem.  Apparently SlimServer just grabs the "nominal bitrate" data from the Ogg file and considers it the actual bitrate--this is not the case.  The nominal bitrate is of fairly marginal value, though, and a calculated average bitrate would be better.
Comment 6 Andy Grundman 2007-07-28 19:52:45 UTC
Yep, no reason not to do this.  Added in change 12438 (trunk) and change 12439 (6.5.4).