Bugzilla – Bug 5130
"Look for new or changed music" causes duplicate "No Album" entries
Last modified: 2007-06-24 20:51:07 UTC
I have been removing some ALBUM tags from tracks where I have only ripped a single song from an album, as I prefer these to appear under "No Album" (I treat them as singles). If I then do a "Look for new or changed music" rescan, the scanner moves the changed songs to appear within a new "No Album" entry, rather than add to the existing "No Album" entry. The more rescans I do, the more entries I get. Once, I found that the original "No Album" entry disappeared (I had a couple of "No Album" entries, which correlated to recent rescans, but not the bulk of my "No Album" songs, from my last full scan). I can correct the music library by doing a full rescan, but this of course takes a lot longer.
I've had this in my local copy for a couple of weeks already to deal with this exact issue. Not committed until it was tested more, but I have no time. Add after line 1907 of Slim/Schema.pm (in _postCheckAttributes) # let the external scanner make an attempt to find any existing "No Album" in the # database before we assume there are none from previous scans $_unknownAlbum = Slim::Schema->rs('album')->searchNames($string)->first;
in trunk at chagne 12285. give it a try and reopen if you find any problems with it.
Is that 7.0 only, or 6.5.3? I updated to latest 6.5.3 and didn't notice any change to Slim/Schema.pm.
This would be great to fix in 6.5.3 as well if possible, KDF
I had a look at applying the patch to my copy of 6.5.3 branch, but $string doesn't exist in the function, so I have taken a guess at what the patch should be: # let the external scanner make an attempt to find any existing "No Album" in the # database before we assume there are none from previous scans $_unknownAlbum = Slim::Schema->rs('album')->searchNames(string('NO_ALBUM'))->first; I applied this just above the following lines: # Create a singleton for "No Album" # Album should probably have an add() method
Kevin, can this be safely targeted for 6.5.3?