Bug 5129 – Snow plugin suffering from global warming - doesn't load

Bug 5129 - Snow plugin suffering from global warming - doesn't load

Summary:

Snow plugin suffering from global warming - doesn't load

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Plugins
Version:	7.0
Platform:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assigned To:	Squeezebox QA Team email alias

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-06-21 14:08 UTC by Michael Herger
Modified:	2008-12-18 11:12 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Fix for Snow screensaver (12.36 KB, patch) 2007-08-06 13:19 UTC, James Craig	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Herger 2007-06-21 14:08:52 UTC

The Snow plugin won't load:

[23:07:38.0375] Slim::bootstrap::tryModuleLoad (246) Warning: Module [Slim::Plugin::Snow::Plugin] failed to load:
Undefined subroutine &Slim::Display::Display::symbol called at /Users/mh/Documents/workspace/slimpy/Slim/Plugin/Snow/Plugin.pm line 441.
Compilation failed in require at (eval 442) line 2.
BEGIN failed--compilation aborted at (eval 442) line 2.

Comment 1 KDF 2007-06-21 18:18:30 UTC

change 11071 removed support for Display::symbols. a problem for snow as the client isn't always known at the time some of the symbols are defined in the plugin.  I'm sure it was noted at the time as in need of a rewrite but buried in a long list of todo's

Comment 2 Adrian Smith 2007-06-22 11:36:41 UTC

Yes - snow needs rewriting...  Its not been maintained with the changes to trunk for other things too.  

Is it really a plugin which should continue to be shipped by default with the server?

Comment 3 James Craig 2007-08-06 13:19:07 UTC

Created attachment 2080 [details]
Fix for Snow screensaver

Attached is a patch to fix the screensaver. 
I also added support for the 2nd screen on a Transporter (same snow as the 1st screen!)

Comment 4 Adrian Smith 2007-09-18 14:41:14 UTC

James - patch applied in r13083.  Thanks.

Michael/QA - could you close this if it is ok?

Comment 5 KDF 2007-09-18 14:53:26 UTC

thats change 13083 for the link :)

Comment 6 Michael Herger 2007-09-19 01:33:21 UTC

Thanks :-)

Comment 7 Ross Levine 2007-09-19 13:24:42 UTC

Verified to be fixed.

Comment 8 James Richardson 2008-05-15 13:04:52 UTC

This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html