Bug 5127 - server settings -> plugins pull down menu doesn't work with Internet Explorer
: server settings -> plugins pull down menu doesn't work with Internet Explorer
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-19 15:19 UTC by Ross Levine
Modified: 2008-12-18 11:12 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Allow dynamic update of plugins.html (4.40 KB, patch)
2007-06-20 14:14 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Levine 2007-06-19 15:19:20 UTC
From the web UI go to server settings then click plugins from the pull down menu at the top. Internet Explorer only, not an issue with firefox.
Comment 1 KDF 2007-06-19 22:35:49 UTC
not good.  full on crashes safari.
Comment 2 Michael Herger 2007-06-20 05:23:50 UTC
Kevin - prototype.js 1.5.1.1 was released yesterday, fixing a potential crasher with Safari (http://www.prototypejs.org/2007/6/20/prototype-1-5-1-1-bugfix-release). Could you please give it another try (don't have my Mac here at work to test with).

Change 12277 - updating prototype.js
Comment 3 Michael Herger 2007-06-20 05:55:41 UTC
As for the main problem here: MSIE doesn't like nested forms. settings/server/plugin.html is the only settings page which comes with it's own form. Disable it and MSIE is happy.

OTOH submitting that resulting form will then do a full reload of the page, resulting in a settings page _without_ submit button. These page refreshes without full reload lead to some new trouble...
Comment 4 KDF 2007-06-20 07:58:30 UTC
new prototype solves the crasher. wonder if it would be feasible to take the form out of the header/footer.  Let the templates set up each.  It would then also avoid the need for settings.js to update the action.  the submit button shout be able to be made into it's own javascript hotspot that triggers a submit of the form (they'd have to have to use the standard name and id, of course.

Comment 5 Michael Herger 2007-06-20 09:28:32 UTC
prototype.js - good timing :-).

As for the button: I have considered moving the button to the top, next to the selector box. This would simplify some of the settings page (the "frame" rendering). I'll give this a try.
Comment 6 Michael Herger 2007-06-20 14:14:26 UTC
Created attachment 2051 [details]
Allow dynamic update of plugins.html

Please give this a try...
Comment 7 Ross Levine 2007-06-20 19:04:39 UTC
It works! Note: need to change the paths in your patch from:

/Users/mh/Documents/workspace/slimpy/HTML/EN/html/settings.js
/Users/mh/Documents/workspace/slimpy/HTML/EN/settings/server/plugins.html

to:

C:\Program Files\SlimServer\server\HTML\EN\html\settings.js
C:\Program Files\SlimServer\server\HTML\EN\settings\server\plugins.html

After that and applying the patch, server settings -> plugins now works in IE. 

Thanks Michael!
Comment 8 Michael Herger 2007-06-21 06:02:47 UTC
Change 12282 - please test
Comment 9 Ross Levine 2007-06-21 13:14:55 UTC
Verified as fixed, thank you again Michael. 
Comment 10 James Richardson 2008-05-15 13:04:51 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html