Bug 5123 – Switch to Squeezenetwork link missing in some skins

Bug 5123 - Switch to Squeezenetwork link missing in some skins

Summary:

Switch to Squeezenetwork link missing in some skins

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	SqueezeNetwork Integration
Version:	6.5.2
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Squeezebox QA Team email alias

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-06-15 20:15 UTC by KDF
Modified:	2008-12-18 11:12 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
remove hardcode link, create in Slim/Web/Pages/Home.pm (1.05 KB, patch) 2007-06-15 20:15 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description KDF 2007-06-15 20:15:09 UTC

EN/home.html is hardcoded to provide a squeezenetwork link.  Any other skin making use of its own home.html will not have this link (fishbone, nokia, moser, nbmu and handheld for example)

Adding the link programmatically allows it to appear in all skins.  patch shortly.

Comment 1 KDF 2007-06-15 20:15:53 UTC

Created attachment 2044 [details]
remove hardcode link, create in Slim/Web/Pages/Home.pm

Comment 2 Chris Owens 2007-06-18 11:58:01 UTC

This seems to work in my quick check.  Is there any reason not to go ahead and commit this to 6.5.3?  It looks straightforward to me, and as always I'd rather get changes in sooner rather than later to allow more user eyes to test for me.  :)

Comment 3 KDF 2007-06-18 12:06:55 UTC

no reason that I know of, but I cc'd andy in case there was some reason he chose to have it hardcoded.  One possibility is that the  server side lists alphabetically, while hard coding can force the link to be last no matter what.  I guess it depends on how important that is.

Comment 4 KDF 2007-06-20 23:09:05 UTC

committed to trunk at change 12279
and to 6.5.3 at change 12280
please reopen if there are any issues.