Bug 5081 - On Debian, look for custom.map/ir files in /etc/slimserver
: On Debian, look for custom.map/ir files in /etc/slimserver
Status: NEW
Product: Logitech Media Server
Classification: Unclassified
Component: IR
: 6.5.2
: PC Debian Linux
: -- enhancement (vote)
: Future
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-23 06:56 UTC by Marc Sherman
Modified: 2011-11-06 23:25 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Sherman 2007-05-23 06:56:45 UTC
Currently in 6.5.2, only the packaged IR dir is searched for .ir and .map files. This patch adds /etc/slimserver to the IR search path on Debian, so that user customized IR files can be kept with other prefs files.

I'm not sure if this is applicable to the 7.0 branch.

--- /usr/share/perl5/Slim/Utils/OSDetect.pm.orig        2007-05-23 09:41:33.000000000 -0400
+++ /usr/share/perl5/Slim/Utils/OSDetect.pm     2007-05-23 09:45:11.000000000 -0400
@@ -152,10 +152,18 @@
        # Debian specific paths.
        } elsif (isDebian()) {

-               if ($dir =~ /^(?:Plugins|Firmware|Graphics|HTML|IR|MySQL|SQL|lib|Bin)$/) {
+               if ($dir =~ /^(?:Plugins|Firmware|Graphics|HTML|MySQL|SQL|lib|Bin)$/) {

                        push @dirs, "/usr/share/slimserver/$dir";

+                } elsif ($dir eq 'IR') {
+
+                        # Look for default IR files in /usr/share,
+                        # and custom overrides in the config dir
+
+                        push @dirs, "/usr/share/slimserver/IR";
+                        push @dirs, "/etc/slimserver";
+
                } elsif ($dir eq 'strings' || $dir eq 'revision') {

                        push @dirs, "/usr/share/slimserver";
Comment 1 Chris Owens 2007-05-29 11:59:07 UTC
I'm reluctant to put this in to 6.5.3 because it's meant to be basically a bug-fix release, without much in the way of new features.

I'll leave it open though in case many other users are interested.
Comment 2 Marc Sherman 2007-05-29 12:02:24 UTC
(In reply to comment #1)
> I'm reluctant to put this in to 6.5.3 because it's meant to be basically a
> bug-fix release, without much in the way of new features.

Ok. 

I would like to try to change your mind about that -- it's worth noting that requiring users to put files into /usr/share to customize the IR mapping is considered a policy violation on a debian system, and as such, it would be a (release critical) serious bug that would push slimserver out of a stable release if not fixed.
Comment 3 Alan Young 2011-11-06 23:25:14 UTC
Unassigned bugs cannot have a priority.