Bugzilla – Bug 5080
Live search doesn't display artist with albums
Last modified: 2008-12-18 11:12:53 UTC
I just noticed that the live search doesn't display the artist for albums that it finds, as the non-live version of the same search does. If this is done for speed purposes (rather than being an oversite) then please disregard.
The live search is hard-coded server side, so it is far less feature-rich than manual search as far as links. Speed was certainly a consideration, although not sure we'd see much of a hit at this point as we have an object already available in that bit of code.
Created attachment 2027 [details] show artist/year on prefs
Had to patch it by hand (damned TortoiseSVN) but here are the error I get: Global symbol "$prefs" requires explicit package name at C:\Program Files\SlimServer Dot6\server/Slim/Web/Pages/LiveSearch.pm line 157. Global symbol "$prefs" requires explicit package name at C:\Program Files\SlimServer Dot6\server/Slim/Web/Pages/LiveSearch.pm line 166.
sorry...patch was against trunk. $prefs->get = Slim::Utils::Prefs::get
Thanks. Works just fine in 6.5. Follows the formatting prefs and everything.
I'll target for 6.5.3 since it's an easy and tested patch, but need to look at the performance hit, as the $item->artists call is yet another poke at the db.
Any chance someone in QA could load this up on an Infrant NAS with a fairly large library and do a few performance tests? That should be pretty close to a worst-case environment.
I'll see what I can do.
Steven to have a look on a particularly slow machine.
(In reply to comment #4) > sorry...patch was against trunk. > > $prefs->get = Slim::Utils::Prefs::get > KDF, I am trying to apply this patch to SlimServer running on an older mac for performance testing. I was able to successfully edit LiveSearch.pm but I do not know what to do with the above information for the patch to work. What am I missing? Thanks!
If you've edited LiveSearch.pm from a copy of 6.5.x then you need to make one further fix (The patch was assuming code from 7.0, trunk). replace every case of: $prefs->get with: Slim::Utils::Prefs::get That will allow the patched LiveSearch.pm to run with 6.5.3
Thanks, I give that a shot.
any news? I can commit any time if we are sure it won't cause livesearch to start lagging too much.
Moving 6.5.3 target bugs to 6.5.4.
committed to trunk at change 12402, can merge to 6.5.4 if testing shows that the performance doesn't suffer. If nothing is going on that, then lets target for 7 and I'll put in the changelog entry. Either way..
this isn't going to make 6.5.4 so I'll add the changelog note for 7 and close off tonight.
changelog entry in 12584. marking as fixed. please reopen if there are any problems.
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.