Bug 5062 - Hebrew string appears incorrectly on player UI
: Hebrew string appears incorrectly on player UI
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Localization
: 6.5.2
: PC Windows XP
: P3 minor (vote)
: Future
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-14 23:00 UTC by Mickey Gee
Modified: 2009-02-17 13:37 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickey Gee 2007-05-14 23:00:13 UTC
Plugin Applications - bad reading order in title 5. Some long items (the are scrolled in the display) are shown when the last part is first, and the item is scrolled to the left (where most of the items are shown from the start and they scroll to the right). For example:  Server http port number under Server info.

Michael H reply: Major change. Post 6.5.2.

No screenshot
Comment 1 Adrian Smith 2007-05-19 06:32:08 UTC
At present the scolling logic does not take account of the language set - it it quesses the direction to scroll based on on the unicode direction of the string - currently only going right to left if there are bidiR but no bidiL characters in the string.  Should we take account of the language too?
Comment 2 KDF 2007-05-19 21:21:36 UTC
targetting localisations for 6.5.3 so it can be dealt with and we can move on.  Anything requiring more complicated changes may get punted.
Comment 3 Chris Owens 2007-06-21 09:52:37 UTC
How difficult would it be to make this change?  i.e. check the Slimserver language to decide the scrolling direction.
Comment 4 Adrian Smith 2007-06-22 12:11:06 UTC
Its trivial to change, but I wanted to check this is the desired operation - for a Hebrew user with European named song's I got feedback before that this should scroll right to left.

So at present the scrolling direction is automatically based on the unicode direction indicators with the caveat that the mixed case is fixed to right to left.  I think the desired change would be for the mixed case to use the default direction for the current language?
Comment 5 Mickey Gee 2007-06-22 12:31:03 UTC
I agree with you, Triode. It makes sense to me.
Comment 6 Adrian Smith 2007-06-22 12:58:18 UTC
committed to 6.5.3 as change 12293 - please confirm this looks correct.
Comment 7 Andy Grundman 2007-07-12 05:48:06 UTC
Moving 6.5.3 target bugs to 6.5.4.
Comment 8 Adrian Smith 2007-07-12 11:26:17 UTC
Mickey - My view is that this is fixed?
Comment 9 Osama Zaidan 2007-08-22 10:49:55 UTC
When using the Hebrew language option and try reading RSS feeds in the squeezebox, or even playing song, the text is going from left to right. Hebrew is a right to left language 
Comment 10 Adrian Smith 2007-08-22 11:51:21 UTC
At present RSS news will always be left to right, but all other displays should do l->r or r->l depending on the string being shown.
Comment 11 Chris Owens 2007-10-15 17:35:51 UTC
Moving open 6.5.x bugs along to 7.0
Comment 12 Michael Herger 2007-12-21 01:07:23 UTC
Moving post 7.0 - SC7 doesn't feature any update Hebrew localization
Comment 13 Adrian Smith 2007-12-21 09:37:11 UTC
It not clear to me what the remaining bug is here - could we describe it in more detail?
Comment 14 Michael Herger 2007-12-22 01:34:20 UTC
Yes, let's close this bug and re-open if needed. The logic seems correct to me.
Comment 15 James Richardson 2008-12-15 13:07:56 UTC
This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.
Comment 16 Dan Evans 2009-02-05 16:09:10 UTC
This issue is still present when viewing RSS feeds.  Marking this for evaluation to either reopen, or create a separate bug.
Comment 17 Adrian Smith 2009-02-06 09:57:00 UTC
Can you confirm where the RSS feeds are being viewed - which menu?  Is this for the feed name or the contents - are the incorrect ones split into multiple lines?
Comment 18 Dan Evans 2009-02-06 11:26:37 UTC
Customer provided this list of RSS feeds:

http://rotter.net/rss/rotternews.xml
http://www.ynet.co.il/Integration/StoryRss1854.xml
http://www.magazin.org.il/news_xml.asp

When customer enters these into SC 7.3.2 and sets his SB3 to display RSS he sees hebrew characters traveling right to left-- it should be reversed.  This is on the display of the SB3.  Not sure how he's inducing the RSS display.

I tried this also and can confirm.  I reproduced by setting the RSS screensaver to display when idle.
Comment 19 Adrian Smith 2009-02-06 11:37:00 UTC
So if this is with RSS screensaver then I know why - the scolling mode ("ticker") does not currently support scrolling in the reverse direction.  One of the reasons is that I didn't know how this should work for mixes of right to left and left to right text.  It may be possible if we assume all the text is reversed, but its not supported by the current code.

Suggest we make this an enhancement request?
Comment 20 Mickey Gee 2009-02-06 11:59:53 UTC
It would be best to scroll right-to-left for languages with that characteristic, regardless of whether some left-to-right text appears in the middle of it.

From my quick googling, RSS feeds specify language. However, Hebrew is not a defined language code. 

http://www.rssboard.org/rss-language-codes

Neither is Arabic, another right-to-left language.

Someone would need to look at the specific Hebrew RSS feeds to figure out what they're specifying as language.

Definitely an enhancement request.
Comment 21 Adrian Smith 2009-02-06 12:07:30 UTC
We can get the langugage from the unicode encoding of the string.  The problem is what happens if you have some feeds which are Hebrew and some which are not.  Does the scolling clear the screen and then restart in the other direction?  What if there are multiple entries from one feed which are in different directions?
Comment 22 Mickey Gee 2009-02-06 12:22:08 UTC
I did some more googling.

The link above specifies the language codes allowable by the W3C, which leads to this document:

http://www.ietf.org/rfc/rfc1766.txt and
http://www.w3.org/TR/REC-html40/struct/dirlang.html#langcodes

The Hebrew language code is "he", and Arabic is "ar".

Regarding right-to-left and left-to-right ... clearing the screen when a reverse direction text is encountered would not be a great idea.

In Hebrew, a direction reversal can happen if English is embedded in the text. Possibly appears frequently in an RSS feed. In these cases, the scrolling should continue from right-to-left, but with the English shown correctly from left-to-right.

In all cases, sticking with right-to-left scrolling would be appropriate.




Comment 23 Adrian Smith 2009-02-06 12:29:25 UTC
We already get the direction from the encoding of the string (its in S:D:Lib:Fonts)

"Regarding right-to-left and left-to-right ... clearing the screen when a
reverse direction text is encountered would not be a great idea."

Ticker mode deals with a stream of text strings, the proposal is to drain the screen before displaying the next text string if it is of a differnt direction from the previous one.  This will occur if an RSS feed has a mix of text types.  Otherwise one story would come back the other way when if the next one should scroll the other way!
Comment 24 Chris Owens 2009-02-09 09:42:23 UTC
I think clearing the screen sounds reasonable.  Mickey points out that if there is Hebrew characters in the middle of the string of English characters, for instance, that this will cause some strange behavior.
Comment 25 Adrian Smith 2009-02-17 13:37:28 UTC
I've added trial support for right to left scrolling of Hebrew/other languages in RSS screensaver to 7.4.  Please try the latest 7.4 nightly to see if it works.

Note - if you have an RSS feed which includes both left to right and right to left languages then it may reverse direction, but if a feed is always the same way round then it should continue scrolling that way.