Bug 505 – Removing last song in playlist causes weird display

Bug 505 - Removing last song in playlist causes weird display

Summary:

Removing last song in playlist causes weird display

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Playlists
Version:	unspecified
Platform:	PC All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:	339
Blocks:
	Show dependency tree / graph

Reported:	2004-08-21 19:30 UTC by Jacob Potter
Modified:	2008-09-15 14:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jacob Potter 2004-08-21 19:30:31 UTC

This one is hard to explain, so I'll start with the steps to reproduce:
1) Queue up a playlist of a few songs (more than 1)
2) Start playing the last song, then press "pause" or "stop"
3) Remove the song from the playlist

Result: "Now stopped on (17 of 16): <first song in playlist>"

I also get the following line printed out 3 times from slimserver.pl:
Use of uninitialized value in array element at
/home/jacob/slim/server/Slim/Player/Playlist.pm line 39.

This seems to be caused by attempting to access the invalid playlist item (#17
in this case).

The glitch occurs via the web interface as well as on the player itself. It will
not happen if the song is playing as it is removed.

Using latest Slimserver from CVS on Linux, if it makes any difference.

Comment 1 Jacob Potter 2004-08-22 07:54:35 UTC

One other thing - if the song is playing while it is removed, the weird "12 of
11" -type display does not occur, BUT the player jumps to the first song of the
playlist. The preferable result would be for it to start playing the new last
song of the playlist.

Comment 2 KDF 2004-09-01 23:53:35 UTC

a patch in bug339 will prevent the warning for Playlist.pm 39.
patch for Bug513 will avoid the (17 of 16) problem.

Comment 3 Chris Owens 2006-06-16 14:40:29 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.