Bug 5028 – "Select Player Font" dropbox not completely localized

Bug 5028 - "Select Player Font" dropbox not completely localized

Summary:

"Select Player Font" dropbox not completely localized

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.5.2
Platform:	PC Windows XP

Importance:	P3 minor (vote)
Target Milestone:	---
Assigned To:	Michael Herger

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-05-12 23:23 UTC by Mickey Gee
Modified:	2008-12-18 11:12 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Screenshot (6.32 KB, image/gif) 2007-05-12 23:23 UTC, Mickey Gee	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mickey Gee 2007-05-12 23:23:13 UTC

Report from team testing translation of SlimServer to German that the dropbox on this screen
was not completely localized to German. Probably an issue for all other languages.

Screenshot to follow.

Comment 1 Mickey Gee 2007-05-12 23:23:41 UTC

Created attachment 1979 [details]
Screenshot

Comment 2 KDF 2007-05-13 10:51:30 UTC

*** Bug 5019 has been marked as a duplicate of this bug. ***

Comment 3 Chris Owens 2007-05-15 16:23:07 UTC

*** Bug 5061 has been marked as a duplicate of this bug. ***

Comment 4 KDF 2007-05-15 22:46:42 UTC

This appears to do the trick.  Using getString means we'll avoid a warning in the logs if there is no string defined in strings.txt for the given language.  I included the german strings given in one of the other dupes.

Index: Slim/Web/Setup.pm
===================================================================
--- Slim/Web/Setup.pm   (revision 12022)
+++ Slim/Web/Setup.pm   (working copy)
@@ -2418,7 +2418,7 @@
        foreach my $f (@$fonts) {
                if ($displayHeight == Slim::Display::Lib::Fonts::fontheight($f . '.2') && 
                        Slim::Display::Lib::Fonts::fontchars($f . '.2') > 255 ) {
-                       $allowedfonts{$f} = $f;
+                       $allowedfonts{$f} = Slim::Utils::Strings::getString($f);
                }
        }
 
Index: strings.txt
===================================================================
--- strings.txt (revision 12022)
+++ strings.txt (working copy)
@@ -8585,6 +8585,22 @@
        NL      Hoog
        ZH_CN   高
 
+FULL
+       DE      Voll
+       EN      Full
+
+LIGHT
+       DE      Klein
+       EN      Light
+
+THREELINE
+       DE      3 Zeilig
+       EN      Threeline
+
+STANDARD
+       DE      Standard
+       EN      Standard
+
 TITLEFORMAT
        CS      Formát názvu skladby
        DA      Format for sangtitler

Comment 5 Michael Herger 2007-05-16 00:31:04 UTC

Thanks KDF. Looking good. But Eric (localization manager) is leaving for a two weeks vacation. This therefore won't make it into 6.5.2.

Comment 6 Chris Owens 2007-05-17 14:20:39 UTC

Most users don't change the player font and 'Standard' is the same in both languages.

Comment 7 KDF 2007-05-17 14:33:02 UTC

and since Michael feels this isn't safe for 6.5.2, lets punt to 6.5.3 now that it's available.

Comment 8 Michael Herger 2007-05-17 14:48:17 UTC

we don't have translations except for Hebrew

Comment 9 KDF 2007-05-22 20:06:39 UTC

now in trunk at change 12089, and 6.5.3 at change 12090
awaiting translations for everything aside from EN and DE.

Comment 10 Chris Owens 2007-05-29 12:47:31 UTC

Another bug that appears to be waiting on translations.

Comment 11 Mickey Gee 2007-06-22 10:34:41 UTC

Change 12286 -- June 22 2007 build