Bugzilla – Bug 4976
InstallShield: Hebrew: Grammar on some sentences are not right.
Last modified: 2009-09-08 09:27:44 UTC
Steps: 1. On a clean ghost of XP SP2 with Hebrew support, install SlimServer 6.5.2, build 2007-05-08. 2. Ask a friend who knows Hebrew to look at every InstallShield page. 3. Notice the grammar on some sentences are not right. The periods are on the right ends of the sentences, instead of on the left. Some words on some sentences are not in the correct order.
Has this been better before? Our translators insisted in "improving" the Hebrew installer strings. If the periods & co. have moved the wrong way, we'll have to check with them.
I need to ask Tomer about this. Since all string had been translated, grammar issue should be an enhancement request. I am setting it as such.
I'm talking to Tomer right now, and basically what he points out is that every sentence in the installer that includes an untranslated string is gramatically backwards. For instance, if there is a sentence that is composed of three strings, such as: (This wizard will install) (Slimserver 6.5.2) (on your computer). The first and third strings are translated, and the second is not, which is expected. However on the screen the resulting sentence appears backwards, like this: (on your computer) (Slimserver 6.5.2) (this wizard will install). I don't know what the solution is to this problem. Perhaps there is a global in the installer to which we can refer to see if the current language is back-to-front, and reverse the concatenation order of the strings if so? As you can see, typically the resulting strings are understandable but gramatically wrong (and kind of stupid-looking).
I believe that this can be addressed by editing the Hebrew.isl file t Tomer: can you look at the file at http://svn.slimdevices.com/*checkout*/branches/6.5/platforms/win32/installer/Hebrew.isl and look for the strings in question and see if it's an easy edit?
Here in Windows land, we had to look at that file on my Hebrew windows image in order to actually see the text (although we could probably do it just adding hebrew support). Once we got the correct encoding set, Tomer said it did look hopeful, like we could just edit the appropriate strings. However, there would still be other anomalies. Like he noticed the periods (end-of-sentence punctuation) were also in the wrong place, and multi-line sentences wrap incorrectly. I'm starting to think the best solution would be to drop Windows support (joke). He left for the day, but he can try to actually edit the file tomorrow if that's the next step.
Chris, we were able to open and "correctly" edit the file in EditPad Lite, with Options/Fonts set to Hebrew. The other non latin western characters (French accents, German umlauts) won't display properly, but survive. You can always switch between Hebrew/Western font setting.
Verified the fix with SlimServer 6.5.2, build 2007-05-11, on XP SP2 with Hebrew support. Bug as written is no longer seen. All sentences seem to be from right to left now. Periods and question marks are on the left hand side. Great work. Marking it as "FIXED".
Even the SlimServer web page starts in Hebrew. This is great job. It is very convient for people to use now. Regression tests found nothing broken because of this fix. Marking this as "VERIFIED".
Closing.