Bug 4922 – When PlayList is empty, Download brings up a blank web page and gets stuck there.

Bug 4922 - When PlayList is empty, Download brings up a blank web page and gets stuck there.

Summary:

When PlayList is empty, Download brings up a blank web page and gets stuck th...

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5.2
Platform:	PC Windows Vista

Importance:	P2 minor (vote)
Target Milestone:	---
Assigned To:	Squeezebox QA Team email alias

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-04-17 16:57 UTC by Wallace Lai
Modified:	2008-12-18 11:12 UTC (History)
CC List:	2 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Wallace Lai 2007-04-17 16:57:38 UTC

Sys Info:  Gateway, P4, 2.00 GHz, 1.25 GB of RAM, Vista SP0 ENU

Steps:
1.  On a clean ghost of Vista, install SlimServer 6.5.2 of build 2007-04-17.
2.  Start SlimServer.
3.  Start the web interface.
4.  Go to bagpuss style.
5.  With PlayList empty, click "Download".
6.  Notice a web page pops up, but it never finishes loading.

Work Around:
Add some songs to the PlayList first.  Media Player pops up nicely when Download is clicked.

Comment 1 KDF 2007-04-18 14:06:57 UTC

Best solution is for the download/clear links to only appear if there is a playlist to act on. To do this for all skins (those properly using the hreftemplate), the EN/hreftemplate blocks can change like so:

[%#href for downloading the current playlist %]
[% BLOCK downloadPlaylistLink; downloadString = "DOWNLOAD" | string -%]
	[% IF playlist_items %][% "<a href=\"status.m3u?player=$playerURI\" target=\"";$target or 'playlist';"\">";img or downloadString;"</a>" -%][%- END %]
[%- END %]

[%# href for clear current playlist command %]
[% BLOCK clearPlaylistLink; clearString = "CLEAR" | string -%]
	[% IF playlist_items %][% "<a href=\"$statusroot?p0=playlist&amp;p1=clear&amp;player=$playerURI\" target=\"";$target or 'status';"\" >";img or clearString;"</a>" -%][%- END %]
[%- END %]

Comment 2 Chris Owens 2007-04-18 14:27:06 UTC

I'd actually rather not fix this for 6.5.2 for fear of affecting this rather central part of Slimserver in some unexpected way.

Comment 3 KDF 2007-04-23 20:00:51 UTC

in trunk at change 11801
reopen if any issues come up

Comment 4 Wallace Lai 2007-04-24 15:50:13 UTC

Verified the fix with 6.5.2, build 2007-04-24, on Vista SP0 ENU.  Bug as written is no longer seen.  Marking as Verified.  Will close.  Regressed other functions in PlayList.  Nothing seems to be broken.

Comment 5 Wallace Lai 2007-04-24 15:50:42 UTC

Marking as CLOSED.