Bug 4911 - Nokia770: not supported with IE
: Nokia770: not supported with IE
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.5.2
: PC Windows XP
: P5 minor (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-04-13 13:37 UTC by Wallace Lai
Modified: 2008-12-18 11:11 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Nokia770 skin bug. (2.25 MB, image/bmp)
2007-04-13 13:39 UTC, Wallace Lai
Details
proposed patch (648 bytes, patch)
2007-05-09 23:25 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wallace Lai 2007-04-13 13:37:24 UTC
System Info:  Gateway, P4, 2.0 GHz, 1.25 GB in RAM, XP SP2, IE 6.0.2900.2180
SlimServer Version:  6.5.2 - 11726
Perl Version:  5.8.8 MSWin32-x86-multi-thread
MySQL Version:  5.0.22-community-nt

Steps:
1.  Start SlimServer.
2.  Start the web interface.
3.  Go to the Nokia770 skin.
4.  Go to the Music Folder.
5.  Notice many buttons and links, such as "Home", are not visible.
6.  Notice there is no scroll bar to go up and down to find songs.  The wheel on mouse does not work either.  Songs below the bottum of the screen are not reachable.
Comment 1 Wallace Lai 2007-04-13 13:39:52 UTC
Created attachment 1904 [details]
Nokia770 skin bug.
Comment 2 Wallace Lai 2007-04-13 13:55:36 UTC
Checked other areas of Nokia770 skin, such as Server Settings,a nd Player Settings.  This skin is almost completely unusable.  There is no scroll bar to navigate, texts are overlapping, and all the pages are a mess to look at.  
Comment 3 Wallace Lai 2007-04-13 16:00:26 UTC
The "Server Settings" and "Player Settings" texts are not visoble until moused over.
Comment 4 KDF 2007-04-13 19:26:16 UTC
Ben has said many times that the nokia770 skin is not intended to work with IE as it is purpose designed for the Nokia770/800 series of devices.  
Comment 5 Chris Owens 2007-04-16 11:09:57 UTC
Reduced the severity and priority to reflect the reduced importance of this bug.
Comment 6 KDF 2007-04-30 21:43:16 UTC
better summary to reflect the full state of the bug.
Comment 7 Wallace Lai 2007-05-01 10:42:25 UTC
Should IE users be blocked from getting into this skin?  A more visible notice can be helpful.  Maybe in the getting started page, or in the SqueezeBox user menu.
Comment 8 KDF 2007-05-01 21:36:05 UTC
another option, since Nokia770 is very platform specific we could redirect anything aside from the actual Nokia770 browser to the Touch skin, which is very much based on Nokia770 skin and should be better at working with IE.
Comment 9 Chris Owens 2007-05-03 15:56:32 UTC
Did you test 'Touch' Wallace?  Did it work better?
Comment 10 Wallace Lai 2007-05-03 16:18:05 UTC
Yes, the "Touch" skin definitly works better.  "Nokia770" and "Touch" do look almost the same.  Redirecting it is a good way to fix this problem.
How much code change will this take?  How risky is this?  We are very close to RC now.
Comment 11 KDF 2007-05-09 22:32:38 UTC
Ok, I've looked into the cause of this.  It's all due to the use of "position: fixed" in the nokia skin stylesheet.  Tihs allows the top and bottom bar to remain fixed in position while scrolling the browse lists.  IE, however, is a miserable failure at supporting "position: fixed". Touch does this by using ablsolute instead, but also does not have the need to restrict the geometry to fit a specific device's screen.

Before I forget, a way to redirect would be to detect the user-agent from the request, like so:

if ($request->header('user-agent') =~ /MSIE/) {
 <if requested skin is nokia, set to touch>
}
Comment 12 KDF 2007-05-09 23:25:09 UTC
Created attachment 1942 [details]
proposed patch

This detects the MSIE user agent in the http request header, then checks for the current skin pref, or the path override.  If it find Nokia770, it forces a skinoverride to Touch so that IE sees a working skin.
Comment 13 KDF 2007-05-10 09:08:54 UTC
Comment on attachment 1942 [details]
proposed patch

sorry, that prefs->get should be Slim::Utils::Prefs::get
Comment 14 KDF 2007-05-10 17:51:57 UTC
committed to trunk at change 11962 and 6.5.2 at change 11963
Comment 15 Wallace Lai 2007-05-11 09:44:42 UTC
Verified the fix with SlimServer 6.5.2, build 2007-05-11 on XP SP2 ENU.
Bug as written is no longer seen.  Scroll bar is there, and icons for Home, PlayList, and others are all visible.  Regression tests around turns up some other issue that I am investigating.  As for this bug, it is fixed.  Marking it as "VERIFIED".
Comment 16 Wallace Lai 2007-05-11 09:45:21 UTC
Closing.