Bugzilla – Bug 4908
Dark Skin: Some text overlap.
Last modified: 2008-12-18 11:11:58 UTC
System Info: Gateway, P4, 2.0 GHz, 1.25 GB in RAM, XP SP2, IE 6.0.2900.2180 SlimServer Version: 6.5.2 - 11726 Perl Version: 5.8.8 MSWin32-x86-multi-thread MySQL Version: 5.0.22-community-nt Steps: 1. Start SlimServer. 2. Start the web interface. 3. On the default skin, check out the All Songs page. All info are lined up neatly. 4. Go to Dark skin. 5. Check out the All Songs page. 6. Notice some lines overlap one another.
Created attachment 1902 [details] Some lines overlap on Dark skin.
This should fix things for EN and Dark skins. (and any that use the text links instead of having images) Index: HTML/EN/slimserver.css =================================================================== --- HTML/EN/slimserver.css (revision 11761) +++ HTML/EN/slimserver.css (working copy) @@ -78,7 +78,7 @@ .browsedbListItem { position: relative; - padding-right: 100px; + padding-right: 120px; } .playlistControls {
better solution, that makes allowance for the musicmagic links: Index: HTML/EN/slimserver.css =================================================================== --- HTML/EN/slimserver.css (revision 11761) +++ HTML/EN/slimserver.css (working copy) @@ -78,7 +78,6 @@ .browsedbListItem { position: relative; - padding-right: 100px; } .playlistControls { @@ -88,9 +87,7 @@ } .browsedbControls { - position: absolute; - top: 0px; - right: 0px; + text-align:right; } div#browsedbHeader {
Created attachment 1914 [details] for your approval given that this does change the look at bit, forcing the controls onto a second line, I thought I'd get a ruling. The other option would be to force them back into tables. The latter would be an unfortunate break as this would be changing the EN skin, which all other skins are based upon so skins that properly use css with graphic controls would end up having to have custom templates instead of relying on a common EN template. I could maybe find a way to select tabled/css via template toolkit somehow.
Wallace, please use a compressed format if you must upload a screenshot. Thanks.
KDF, your proposal looks good to me. Wallace, did you have a look? Should we try to get Dean's opinion as well?
I'd like to get Dean's ok as it is a UI issue. I'd guess that the text-based skins are rarely used compared to the more graphic-laden Default/Fishbone/Nokia770 options but this does force the browse list to use two rows instead of one for the text skins even if there is room to fit in one.
ok, decided to just put it in there since it isn't a huge change after all. committed to 6.5.2 at change 11901 and trunk at change 11902 please reopen if there are any problems. This affects EN, Dark, NBMU, bagpuss and purple skins.
Verified the fix with Dark skin of SlimServer 6.5.2, build 2007-05-04, on XP SP2 ENU. Bug as written is no longer seen. Regressed other pages in Dark skin. No other text overlap was found. Marking this as VERIFIED. However, regression tests on skins EN, Bagpuss, and Purple turned up some overlapping text. Logging another bug for them.