Bugzilla – Bug 4891
"Play this song" and "Add this song to playlist" links are not always visible.
Last modified: 2008-12-18 11:11:58 UTC
System Info: Gateway, P4, 2.0 GHz, 1.25 GB of RAM, XP SP2 ENU, IE 6 Perl Version: 5.8.8 MSWin32-x86-multi-thread MySQL Version: 5.0.22-community-nt SlimServer Version: 6.5.2 - 11726 1. On a clean ghost of XP SP2 ENU system, install SlimServer 6.5.2, build 2007-04-04. 2. Go to the Albums. The default Microsoft My Music directory is in it. 3. Inside the music folder, there is a sample "Symphony No. 9". 4. Click this link to see all information about this track. 5. Notice on the top of the track info, the links "Play this song" and "Add this song to playlist" are not always visible. The user must mouse over that empty space to see the links.
Created attachment 1894 [details] Links not visible.
Created attachment 1895 [details] After mousing over, they are visible.
Wallace I'm not seeing this, have you since been able to reproduce it? Possibly a browser artifact?
Hi, Ross, Yes, I am still seeing it. This is very reproducible.
I don't know what I was thinking, sorry. I'm easily reproducing this now too.
should be easily fixed...IF there was something that actually was clearly doing something to the songInfoHeader class/div-id. Unfortunately, I cannot see anything and any check with local files on my setup arent' showing the mouse over problem. If you try EN skin, do you see the same problem?
Not a problem with the EN skin.
so, for kicks, what happens if you erase lines 413-417 from Default/slimserver.css (the div#songInfoHeader block), clear caches and reload. Is the problem gone from default skin then?
No change KDF. Note, this is an IE specific bug. This problem does not occur in FireFox.
grrr...more IE quirks to bite us. line 308 of Default/slimserver.css, change to height: 0; and that should work. Have to see how that's going to affect everything else before we make that permanent.
That fixed it, you're good... KDF what state does that put this bug in? I'm confused about what we do next.
The state doesn't really need to change until I can merge it in with a changelog entry. Then it moves to "fixed". It would be great if you can take a few minutes just to go through a few pages in default skin to make sure it doesn't seem to mess anything up with the current fix. the change does affect a style used on just about every page. There are other ways to do this fix, using an IE quirk hack in songinfo.html if we need to be more specific, but this one change is cleaner overall. I'll put it on my list to merge it into trunk and 6.5.2 once I'm at home tonight and have svn access again. If nothing shows up as broken from the change, the state can move to 'verified' and 'closed' on a review for release I guess.
Thanks KDF. I just took a quick look through the various browse web UI functions and I'm not noticing anything wrong. Is there something else specifically you want me to take a look at? It sounds like you have an idea of what this might conflict with.
I wish I did. IE confuses me, but I do know that it does have some funny behavour on pages when "height" and "width" aren't fixed sizes. Using 0 is something we've dome before, for gallery view. I guess what I worry about is that it might do something funny with the vertical scrollbars or end the page too soon for pages that are shorter than the browser window. Firefox, safari, opera, IE7 might also react differently due to the change. Sadly, I'm no css expert, just someone who has run into a long enough list of boobytraps.
committed ffix to trunk at change 11749 and to 6.5.2 at change 11750. marking fixed, please reopen if side effects are found in any of the supported browsers.
Thanks. This is great. Since this is an intermittent bug, I will need to verify the fix on several builds before closing.
Fixed in 6.5.2, which is now released and available for download at http://www.slimdevices.com/su_downloads.html If you're still experiencing this bug, please re-open it!