Bug 489 – Single Album FLAC w/cuesheet fails to play tracks at > 60 minutes

Bug 489 - Single Album FLAC w/cuesheet fails to play tracks at > 60 minutes

Summary:

Single Album FLAC w/cuesheet fails to play tracks at > 60 minutes

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Transcoding
Version:	5.x or older
Platform:	PC Debian Linux

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-08-08 01:10 UTC by David Lutz
Modified:	2008-12-18 11:55 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Patch to fix (282 bytes, patch) 2004-08-08 01:14 UTC, David Lutz	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Lutz 2004-08-08 01:10:29 UTC

I discovered this bug while try to play later tracks from a single album flac
with an embedded cuesheet.  Tracks that start or end at > 60 mins get flac
commands generated with incorrect --skip and --until parameters.  I traced the
problem down to the fracSecToMinSec() function in Slim/Utils/Misc.pm.  Currently
this function rolls-over the hour when passed fractional seconds > 3600, i.e.
fracSecToMinSec(3850) returns "4:10.00" instead of "64:10.00". I imagine this
bug could cause problems elsewhere as well.  I checked the latest nightly
(2004-08-07) and the problem still exists.

Comment 1 David Lutz 2004-08-08 01:14:34 UTC

Created attachment 95 [details]
Patch to fix

Here is a patch that seems to work just fine for me, I apologize if the patch
isn't in the preffered format.

Comment 2 Blackketter Dean 2004-08-12 10:21:09 UTC

Fixed for the next nightly release.

Comment 3 Blackketter Dean 2004-08-17 10:25:36 UTC

Can you test and close this bug if it's working for you?

Comment 4 David Lutz 2004-08-17 20:15:05 UTC

Tested in the 8/17 nightly.  It works beautifully.  Closing this bug.

Comment 5 Chris Owens 2008-12-18 11:55:04 UTC

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.