Bugzilla – Bug 4824
behavior setting: filter genres at album & track level broken.
Last modified: 2009-09-08 09:25:26 UTC
I have checked the bug lists but could not find this anywhere. Using the web interface, I go to Home / Genres, and am presented with a list of genres. Clicking on one e.g. Jazz, presents a list of artists which feature in that genre. At the top of this list is an option for All Albums. Clicking on this generates a list of all the albums by the artists on the previous page, which in this case are all jazz albums. This screen is titled Home / Genres / Jazz and above all the jazz albums is an option for All Songs. Clicking on the play (>) or add (+) buttons next to "All Songs" correctly inserts all the songs from the listed albums into the current playlist. Clicking on the "All Songs" link itself should (one would imagine) generate a list with all the songs on those albums, but instead it displays a list of every song in the database, with the heading Home / Genres / Jazz. Al Reynolds
I have checked on my Squeezebox and the same behaviour is exhibited there.
I'll take a look at this here later today.
I'm not able to reproduce this. I have 6.5.1 installed on XP and when I browse -> Genres -> Jazz -> I'm only seeing the Jazz Genre artists, then I click All Albums at the top of that list and it's only showing me the list of albums within the Jass Genre, as it should. Do you have any 3rd party plugins installed?
might help to have a look at the url for the 'all songs' url in the problem case (right click, properties). is it in a specific skin or all skins?
(In reply to comment #3) > I'm not able to reproduce this. I have 6.5.1 installed on XP and when I browse > -> Genres -> Jazz -> I'm only seeing the Jazz Genre artists, then I click All > Albums at the top of that list and it's only showing me the list of albums > within the Jass Genre, as it should. No plugins / standard skin. Yes, that (All Albums) works fine. It is the link at the top of that page (All Songs) which then generates the list of every song in the database (rather than just the ones on those albums). So "Home / Genres / Jazz / All Albums" works fine, but "Home / Genres / Jazz / All Albums / All Songs" is broken. Note: only the "All Songs" link is broken - the play/add buttons on the right work fine and put the correct songs in the playlist. All songs link: http://xxx.xxx.xxx.xxx:9000/browsedb.html?hierarchy=genre,contributor,album,track&orderBy=album.titlesort,me.disc,me.tracknum,me.titlesort&level=3&genre.id=4&player=00%3A04%3A20%3A07%3A50%3A73 Play button: http://xxx.xxx.xxx.xxx:9000/status_header.html?command=playlist&subcommand=loadtracks&genre.id=4&player=00%3A04%3A20%3A07%3A50%3A73 Add button: http://xxx.xxx.xxx.xxx:9000/status_header.html?command=playlist&subcommand=addtracks&genre.id=4&player=00%3A04%3A20%3A07%3A50%3A73 The same behaviour is not exhibited in the Artists route through the menu. So "Home / Artists / Nina Simone / All Songs" works fine, as do the Play and Add buttons on the right. All songs link (Artists / Nina Simone): http://xxx.xxx.xxx.xxx:9000/browsedb.html?hierarchy=contributor,album,track&orderBy=album.titlesort,me.disc,me.tracknum,me.titlesort&level=2&contributor.id=98&player=00%3A04%3A20%3A07%3A50%3A73 I stripped this down to a working: http://xxx.xxx.xxx.xxx:9000/browsedb.html?hierarchy=contributor,album,track&level=2&contributor.id=98 and tried similar to browse for a genre: http://xxx.xxx.xxx.xxx:9000/browsedb.html?hierarchy=genre,album,track&level=2&genre.id=4 (I'm not familiar with the query system so I'm not sure if this should have worked, but it didn't - it generated all the songs in the database) Anyway, see if you can reproduce the error with the "All Songs" link...
(In reply to comment #5) > I stripped this down to a working: > http://xxx.xxx.xxx.xxx:9000/browsedb.html?hierarchy=contributor,album,track&level=2&contributor.id=98 > and tried similar to browse for a genre: > http://xxx.xxx.xxx.xxx:9000/browsedb.html?hierarchy=genre,album,track&level=2&genre.id=4 > (not working) Tried to search for all songs in year 1991 with: http://bat400.mine.nu:9000/browsedb.html?hierarchy=year,album,track&level=2&year.id=1991 and it works, so maybe the browsedb.html searches by contributor or year correctly, but not genre?
I've tried the all songs link, and I'm not seeing any problems at all. It correctly brings me to all the songs by the artist within the selected genre. This sounds fairly straight forward if this is indeed broken I shouldn't have such a tough time reproducing it. Perhaps something else is going on here... Have you tried blowing away the database and re-building? Stop SlimServer and delete the cache directory, then restart SlimServer. Does this change anything?
(In reply to comment #7) Thanks for your time and patience Ross, I appreciate it. > I've tried the all songs link, and I'm not seeing any problems at all. It > correctly brings me to all the songs by the artist within the selected genre. You say artist not artists here - that may be accidental but the "All Songs" link works correctly for me on an individual artist. See below for more details. > This sounds fairly straight forward if this is indeed broken I shouldn't have > such a tough time reproducing it. Perhaps something else is going on here... Or I might be going mad! > Have you tried blowing away the database and re-building? Stop SlimServer and > delete the cache directory, then restart SlimServer. Does this change anything? Ok, have done a full rescan - no effect. Have stopped slimserver and mysql, cleared Slimserver cache folder, restarted machine/server - still no effect. Tried clearing browser cache as well - no effect. ------------------------------------------------------------------------- Back to the "All Songs" link - to clarify which "All Songs" link I am talking about: When I go to "Home \ Genres \ Jazz" I see an "All Albums" link, a "Miles Davis" link, and a "Nina Simone" link. If I go to "Home \ Genres \ Jazz \ Nina Simone" I see two albums by Nina Simone. If I click the "All Songs" link above those two albums it correctly displays the tracks on the two albums. If I go to "Home \ Genres \ Jazz \ Miles Davis" I see only the one album by Miles Davis. There is no "All Songs" link above this album as it would be redundant. If I go to "Home \ Genres \ Jazz \ All Albums", however, I see the three albums mentioned above. There is also an "All Songs" link above the three albums (which are by two different artists). Clicking on *this* "All Songs" link loads a page with the entire database on it. So I am looking to find all songs on all albums in the genre Jazz, not all songs by a particular artist. ------------------------------------------------------------------------- PS You can try it yourself and see at the web address mentioned at the bottom of Comment #6. I didn't mean to leave that address in there, so if you could mask it out as I have done with the other addresses I would be very grateful. I couldn't find a way to edit my own comments.
Thanks for clarifying, I'm confident I understand the issue you're describing. However, I'm still unable to reproduce this. Browse -> Genres -> Jazz -> all albums -> all artists shows me exactly what it should show me, all of the songs within the Jazz genre. Again this leads me to believe that this isn't a bug in SlimServer but rather something else causing this. Are you running active perl by chance? Are you manipulating the database on your own? Anything else you can think of that might have something to do with this?
For info: SlimServer Version: 6.5.1 - 11206 - Windows XP - EN - cp1252 Perl Version: 5.8.8 MSWin32-x86-multi-thread MySQL Version: 5.0.22-community-nt (it's pretty much a standard installation) BUT ... I think I have worked out where the problem lies! In Server Settings / Behavior: FILTER GENRES AT THE ALBUM & TRACK LEVEL. Filtering can be done when Browsing Genres to only show the albums & tracks that match the selected genre. The options are: 1. Only show tracks or albums matching the selected genre for an artist 2. Show any tracks & albums for an artist I had option 2 selected - my reasoning for choosing this was that there might be some songs by an artist in a different genre, and I would want to see those songs too. With option 1 selected, the "Genres / Jazz / All Albums / All Songs" link now correctly shows me all the Jazz songs in the albums in the Jazz genre. I have tried tagging one Nina Simone track with a different genre (Pop) to see what happens - that particular song is now not shown by the query (quite correctly because of selecting option 1). Can you check and see if the behaviour I described initially is replicated if option 2 is selected on your setup? If it is then I think this is still a bug - the "Genres / Jazz / All Albums / All Songs" link should either show: (i) just the songs on the albums listed on the "Genres / Jazz / All Albums" page. (ii) all songs by the artists listed on the "Genres / Jazz / All Albums" page. Personally I think it should do (i), but I can see why (ii) more closely matches "Show any tracks & albums for an artist".
Sure enough, theres the problem! Thanks for clarifying Al! It seems the filtering behavioral options is broken, I'll adjust the summary of this bug to reflect this. It seems to me that selecting the option "Show any tracks & albums for an artist" (within a genre selection) should show exactly that, any tracks and albums by said artists. Reproduction steps summarized: Server settings -> behavior -> filter genres at the album & track level -> Show any tracks & albums for an artist. Browse -> Genres -> (choose a genre) -> click all albums -> click all artists. SlimServer doesn't show all tracks and albums in said genre, it shows all albums and artists in the library regardless of genre. Dan let me know if you need anything else.
Marking as viewable only by developers and administrators at the reporter's request. Contact me if you're interested in the reason, and remind me of my email of 3:21pm, 14 Mar 2007.
(In reply to comment #11) > It seems to me that selecting the option "Show any tracks & albums for an > artist" (within a genre selection) should show exactly that, any tracks and > albums by said artists. My only counter to this argument would where artists produce albums in entirely different genres. For example, I have Prince albums where all songs are marked as Pop, or all are marked as Rock. I have one Prince album (original picture score) where all songs are marked as Classical, and other Prince albums with songs marked as a mixture of Pop, Funk and Rock. If I go to Home -> Genres -> Funk I see the artist Prince. If I click on all albums, I only see the Prince albums which contain all or some Funk songs. If I then click on All Songs, I would expect to see all the songs from those albums I had just been looking at i.e. any which contained songs in the selected genre. I would be slightly surprised if the songs from the album containing entirely Classical music appeared when I had been navigating by genre Funk. At the moment the options in Server Settings / Behavior for FILTER GENRES AT THE ALBUM & TRACK LEVEL are: 1. Only show tracks or albums matching the selected genre for an artist 2. Show any tracks & albums for an artist This fits well when you only have one artist in a genre, as the All Songs link will be for one artist, but if you select all albums then the All Songs link is for Albums not Artists. The All Albums link happily shows only those albums which include tracks matching the selected genre. Perhaps the options should be: 1. Only show tracks or albums matching the selected genre for an artist 2. Show any tracks or albums for an artist 3. Show tracks or albums where at least one track on an album matches the selected genre
Can you still reproduce this issue?
Yes, I can still reproduce it but I have switched platform to: SlimServer Version: 6.5.3 - 12376 - Mac OS X 10.4.11 (8S2167) - EN - utf8 Server IP address: 192.168.0.2 Perl Version: 5.8.6 darwin-thread-multi-2level MySQL Version: 5.0.22-standard Before I was on: SlimServer Version: 6.5.1 - 11206 - Windows XP - EN - cp1252 Perl Version: 5.8.8 MSWin32-x86-multi-thread MySQL Version: 5.0.22-community-nt (it's pretty much a standard installation) The problem only appears if in Server Settings / Behavior you have "FILTER GENRES AT THE ALBUM & TRACK LEVEL" set to option 2. Show any tracks & albums for an artist With option 2 selected, the "Genres / Jazz / All Albums / All Songs" link shows me every song in the database, rather than all the songs by the artists listed on that page.
Michael: can you take a look at this?
Al, I meant: can you reproduce this issue with SC7? 6.5.3 isn't even the latest in the 6.x series, and its development has stopped. If you still see it in SC7, we'll have to fix it. Thanks!
OK, it appears to be worse! New platform: SqueezeCenter Version: 7.0 - 15661 - Mac OS X 10.4.11 (8S2167) - EN - utf8 Perl Version: 5.8.6 darwin-thread-multi-2level MySQL Version: 5.0.22-standard Platform Architecture: x86 Now when I click on Home>Genres>Jazz, it shows me the four artists with Jazz albums, but when I click on All Albums, it shows me every album in my database, not just the Jazz ones. If, however, I click on the + symbol to the right of "All Albums", it correctly adds all songs from the shown Jazz artists to the playlist, so the problem appears to be with the query on the "browser" side rather than the "playlist side". As before, this bug only appears if you have Settings > Music Library > Filter genres at the album & track level set to: Show any tracks & albums for an artist If it is set to: Only show tracks or albums matching the selected genre for an artist then it works as it should. So yes, the bug is still there. Let me know if you need any further info, Al
Al - thanks for the update. I'll take a look at this.
fixed in change 15815 - feel free to re-open if needed.
Thanks. I have gone back to 6.5.3 temporarily as SC7 broke my AlienBBC installation on the Mac (paths wrong), but when I upgrade again I will check everything is in order. Al Reynolds
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.