Bug 4737 - Basic search: empty search should say something
: Basic search: empty search should say something
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 6.5.1
: PC Windows XP
: P2 minor (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-05 11:31 UTC by Jim McAtee
Modified: 2008-12-18 11:11 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2007-02-05 11:31:13 UTC
I thought this was already covered, but maybe it was only for Advanced Search.  When a basic search comes back empty, display something on the page to that effect.  Otherwise, it's confusing to run a search and then see nothing but a blank page with a search box and search term.  If you didn't see the page refresh, you wouldn't know you've run the search.
Comment 1 KDF 2007-02-05 13:16:06 UTC
add this before HTML/EN/search.html, line 43

	[% ELSIF manualSearch %]
		[% "NO_SEARCH_RESULTS" | string %]

need a 6.5.2 target on this thing :)
Comment 2 Jim McAtee 2007-02-05 13:36:48 UTC
That works just fine.

Related to this, in Advanced Search can the same string be suppressed when you first enter the form and haven't yet run a search?  At line 185 of advanced_search.html I can't quite figure out what to test in order to tell if a search has been run.  Tried the hidden field thing, but that didn't work.
Comment 3 KDF 2007-02-05 20:01:59 UTC
fixed in trunk at change 11348 and change 11349, 6.5.2 at change 11351

advanced search fixed in trunk at change 11352 and in 6.5.1 at change 11353
please reopen if problems still exist, anything else...my usual rate is a single malt :)
Comment 4 Chris Owens 2007-05-22 12:10:30 UTC
Fixed in 6.5.2, which is now released and available for download at http://www.slimdevices.com/su_downloads.html

If you're still experiencing this bug, please re-open it!