Bug 4726 – Formatting settings ignored in browse Ablums

Bug 4726 - Formatting settings ignored in browse Ablums

Summary:

Formatting settings ignored in browse Ablums

Status:	RESOLVED INVALID

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5.1
Platform:	PC All

Importance:	P2 minor (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-02-01 13:17 UTC by Jim McAtee
Modified:	2007-02-01 16:19 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jim McAtee 2007-02-01 13:17:24 UTC

In browse Albums, the two formatting settings "Show artist with albums" and "Show year with albums" are ignored when set to "Disabled" and that field is then used as the first sort field.

For example, disable "Show year with albums".  Then browse Albums and vary the sort order.  When the sort is by "Year, Album" or "Year, Artist, Album", the year is still be displayed.

Comment 1 KDF 2007-02-01 15:38:29 UTC

Slim/Schema/Album.pm, near line 108:

	# Show the year if pref set or storted by year first
	if (my $showYear = Slim::Utils::Prefs::get('showYear') || ($sort && $sort =~ /^album\.year/)) {

		$form->{'showYear'} = $showYear;
		$form->{'year'}     = $self->year;
	}

Comment 2 Jim McAtee 2007-02-01 16:19:59 UTC

And looks like the same for artist near line 115.

# Show the artist in the album view
my $showContributor = ($sort && $sort =~ /^contributor\.namesort/);

if (Slim::Utils::Prefs::get('showArtist') || $showContributor) {
  if (my $contributor = $self->contributors->first) {
    $form->{'artist'}        = $contributor;

No problem. Just thought this might have been an oversight rather than intentional.