Bug 4707 - Forcing transcode to MP3 results in a bit rate of 0.
: Forcing transcode to MP3 results in a bit rate of 0.
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Transcoding
: 6.5.1
: All All
: P2 normal (vote)
: 7.x
Assigned To: Spies Steven
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-23 16:31 UTC by Spies Steven
Modified: 2009-07-31 10:14 UTC (History)
0 users

See Also:
Category: ---


Attachments
Log showing 0 bitrate (7.14 KB, text/plain)
2007-01-23 16:32 UTC, Spies Steven
Details
possible fix (1.92 KB, patch)
2007-01-23 22:07 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Spies Steven 2007-01-23 16:31:08 UTC
This is something I came across while doing testing for another bug.

If you force Slimserver to transcode to MP3 by deselecting all other stream format options in "file format conversion setup" will result in a bit rate of 0. I think it should be 320 or at least 128. I also noticed Slimserver defaults to quality level 9 which is probably OK. 

Doing a little investigation it turns out that passing 0 --abr to lame will result in a bitrate around 32 kbps VBR while 0 -b will result in 128 kbps CBR. It all depends what is set up in convert.conf. Is there a reason we mix ABR and CBR in convert.conf? I would think it should all be one or the other. I also noticed that "ape mp3" is set to -q 9 instead of $BITRATE$
Comment 1 Spies Steven 2007-01-23 16:32:54 UTC
Created attachment 1785 [details]
Log showing 0 bitrate
Comment 2 KDF 2007-01-23 18:11:07 UTC
should always be --abr for lame conversions.

forcing mp3 problem is due to the "no limit" option being a value of 0. probably need a sanity check for accepting an mp3 transcoding command with no limit setting.
Comment 3 KDF 2007-01-23 22:07:42 UTC
Created attachment 1786 [details]
possible fix

untested but should stop the problem, and make the abr/cbr results consistent.
Comment 4 KDF 2007-07-18 22:23:48 UTC
change 12309 covers the convert.conf changes for abr.
Comment 5 KDF 2007-07-18 22:28:56 UTC
change 12399 handles the ape-mp3 quality issue
Comment 6 KDF 2007-07-18 22:46:19 UTC
fixed at change 12400.
please verify and reopen if there are problems.
Comment 7 Chris Owens 2008-03-07 09:04:02 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.
Comment 8 James Richardson 2008-10-13 15:24:35 UTC
Verified still a problem in

SqueezeCenter 7.2.1-23518

Playing the file attached to bug 8797 and turning all encoding to disable except LAME, I saw this issue.

Comment 9 James Richardson 2008-10-13 15:28:13 UTC
[08-10-13 15:21:58.6364] Slim::Player::Source::openSong (2104) Streaming with format: mp3
[08-10-13 15:21:58.6377] Slim::Player::TranscodingHelper::tokenizeConvertCommand (388) Using command for conversion: "C:\PROGRA~1\SQUEEZ~1\server\Bin\MSWin32-x86-multi-thread\mov123.exe" "C:\Users\JAMESR~1\Music\01SHED~1.M4A" | "C:\PROGRA~1\SQUEEZ~1\server\Bin\MSWin32-x86-multi-thread\lame.exe" --resample 44100 --silent -q 9 --abr 0 -r --big-endian - - |
[08-10-13 15:21:58.6500] Slim::Player::Source::playmode (412) 00:04:20:1e:04:a4 New play mode: play
Comment 10 James Richardson 2008-10-13 15:28:47 UTC
KDF: Is this yours to fix? or should I assign it to someone else
Comment 11 KDF 2008-10-13 16:48:17 UTC
someone else, please.

Comment 12 Jim McAtee 2008-10-13 17:54:21 UTC
Alan recently made some changes to the mp3 encoding settings in 7.3.  He may have even addressed this one.  See change 23010.
Comment 13 James Richardson 2008-10-14 09:13:43 UTC
QA to re-verify with 7.3
Comment 14 Spies Steven 2008-11-11 16:21:34 UTC
This does appear to be resolved in newer versions of 7.3.

Marking as fixed.
Comment 15 James Richardson 2008-11-19 14:14:41 UTC
Verified SqueezeCenter 7.3.0 23961 works properly with MP3 forced decoding
Comment 16 James Richardson 2008-12-15 12:36:37 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 17 Chris Owens 2009-07-31 10:14:14 UTC
Reduce number of active targets for SC