Bug 4694 – When "Composer, band and orchestra in artists" are disabled, song info items for composer, conductor & orchestra are displayed but show "Empty" when moving right

Bug 4694 - When "Composer, band and orchestra in artists" are disabled, song info items for composer, conductor & orchestra are displayed but show "Empty" when moving right

Summary:

When "Composer, band and orchestra in artists" are disabled, song info items ...

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Player UI
Version:	6.5.1
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-21 03:08 UTC by Nigel Birch
Modified:	2008-12-18 11:12 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
indian summer.mp4, which displays the behavior (3.32 MB, application/octet-stream) 2007-05-17 14:50 UTC, Chris Owens	Details
potential patch (1.18 KB, patch) 2007-05-18 07:11 UTC, Adrian Smith	Details \| Diff
updated patch (2.00 KB, patch) 2007-05-18 07:49 UTC, Adrian Smith	Details \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nigel Birch 2007-01-21 03:08:02 UTC

SlimServer v6.5.1 - TRUNK - Windows XP - EN - cp1252, Perl v5.8.8 MSWin32-x86-multi-thread & MySQL Version: 5.0.22-community-nt.  It's a v6.5.1 branch checkout at r11203 (so should be the same as the v6.5.1 release).

When using the player UI, with all three checkboxes for "Composer, band and orchestra in artists" disabled, song info items for these (composer, conductor & orchestra) are displayed (good) but show "Empty" when moving right (bad).

I don't know what the intended behaviour is, but as stands now, it looks a little odd.  For me, showing the composer, conductor & orchestra info is good and very useful.  I can understand not being able to go right (since they are now longer listed when browsing) but if that's the intended behaviour then a right arrow should not be displayed and one shouldn't be able to go right at all (therefore, "Empty" wouldn't be shown).

An equivalent behaviour is seen in the web UI.  Here, a hyperlink is shown but when it is clicked on a page of blank results is shown.  Again, the better behaviour would be for the composer, conductor & orchestra items not to be hyperlinks (but plain text instead).

Thanks.

Comment 1 Chris Owens 2007-05-17 14:41:34 UTC

The three checkboxes Nigel mentions are in Server Settings -> Behavior

Comment 2 KDF 2007-05-17 14:42:16 UTC

set to investigate for 6.5.3, but no promises if it's not relelated to the other composer issues.

Comment 3 Chris Owens 2007-05-17 14:48:27 UTC

Then I go to the player UI, Browse -> Albums -> [any album] -> [any song with a composer] -> Title: foo

Then down-arrow to the composer, who is shown correctly "Composer: Mark Goldenberg" in my case

But then I do right-arrow on him, and get a screen that says 'Empty'

Comment 4 Chris Owens 2007-05-17 14:50:48 UTC

Created attachment 2019 [details]
indian summer.mp4, which displays the behavior

Comment 5 Adrian Smith 2007-05-18 07:11:18 UTC

Created attachment 2021 [details]
potential patch

Chris, Could you test this potential patch?  I think this should mean we descend using the specified contributor rather than the default artist ones.  I'm not certain about side effects yet, but it would be good to confirm whether it addresses the original problem.

Comment 6 Adrian Smith 2007-05-18 07:49:31 UTC

Created attachment 2022 [details]
updated patch

Comment 7 Adrian Smith 2007-05-22 12:35:35 UTC

patch applied to trunk change 12071.

Comment 8 Ross Levine 2007-05-23 16:29:12 UTC

Looks like that fixed it, if anyone else is still seeing this please feel free to re-open. I'll mark this as fixed and verified as such.

Comment 9 Nigel Birch 2007-05-27 03:00:18 UTC

I just tested with v6.5.3 r12139, with an emptied cache folder, and "Composer" now works fine but "Band/Orchestra" and "Conductor" still show "Empty" when moving right.

Comment 10 Adrian Smith 2007-05-27 07:26:06 UTC

The change was only made to trunk (7.0), do we want this in 6.5.3 too?

Comment 11 Nigel Birch 2007-05-27 10:07:01 UTC

Sorry - I didn't read comment 7 properly.  A fix for v6.5.3 would be great if deemed suitable.

Comment 12 KDF 2007-05-27 11:51:44 UTC

ross seems to have verified the fix works in trunk, so it should be safe to move into 6.5.3 and close this for real :)

Comment 13 Adrian Smith 2007-06-02 03:38:17 UTC

Added to 6.5.3 in change 12192.  Please try the next nightly for 6.5.3 and confirm so this can be closed.

Comment 14 Nigel Birch 2007-06-02 06:00:17 UTC

Works perfectly for me.  Thanks.