Bug 4692 - folder with extension treated as file
: folder with extension treated as file
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 6.5.1
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Squeezebox QA Team email alias
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-21 02:41 UTC by Jason Polychronopoulos
Modified: 2008-12-18 11:12 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
zip containing file/path to reproduce bug (612 bytes, application/octet-stream)
2007-01-21 02:42 UTC, Jason Polychronopoulos
Details
always check for dir before returning type (1.38 KB, patch)
2007-12-10 13:48 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Polychronopoulos 2007-01-21 02:41:39 UTC
A folder with an extension recognised by slimserver is treated as file when doing "Browse music folder"
This didn't happen in 6.3.0

Also it is added as a song in the library by the scanner

To reproduce create something like:

C:\slimserver_folder_file\my_cds.flac\cd1\cd1.txt

And so a music scan with C:\slimserver_folder_file as your music folder
Comment 1 Jason Polychronopoulos 2007-01-21 02:42:14 UTC
Created attachment 1778 [details]
zip containing file/path to reproduce bug
Comment 2 Chris Owens 2007-10-23 10:04:24 UTC
QA to confirm this bug
Comment 3 Chris Owens 2007-12-10 09:28:56 UTC
ping QA
Comment 4 KDF 2007-12-10 12:26:51 UTC
I can reproduce this, I'll look into it.  
Comment 5 KDF 2007-12-10 13:48:31 UTC
Created attachment 2491 [details]
always check for dir before returning type

This unfortunately adds a bit of overhead as we need to process the url into a path and check if it's a directory on every new "track". I've tried to keep it to a minimum and it will still shortcut cached results.
Comment 6 KDF 2007-12-10 14:35:19 UTC
cc'ing andy for a second opinion
Comment 7 Andy Grundman 2007-12-10 14:38:09 UTC
Thanks, that looks OK to me.
Comment 8 KDF 2007-12-10 14:58:24 UTC
change 15147 for Dec 11 build of 7.0a1. please reopen if there are any issues.
Comment 9 Chris Owens 2008-03-07 09:04:47 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.