Bug 4646 - Year on song info page isn't a hyperlink with Nokia770 skin
: Year on song info page isn't a hyperlink with Nokia770 skin
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 6.5.1
: PC Windows XP
: P2 enhancement (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-09 02:50 UTC by Nigel Birch
Modified: 2008-12-18 11:11 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Makes the year a hyperlink (585 bytes, patch)
2007-01-09 02:51 UTC, Nigel Birch
Details | Diff
Removes target attribute from artist hyperlink (776 bytes, patch)
2007-04-27 15:59 UTC, Nigel Birch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nigel Birch 2007-01-09 02:50:26 UTC
On the song info page (HTML/Nokia770/songinfo.html), the year is shown as plain text and is not a hyperlink to show all albums from that year.  Perhaps there's a reason why it's not done, but here's a patch against 6.5.1 to make it a link.

The patch doesn't specify a target= attribute for the link (so is like the album and genre links) since specifying target=\"browser\" (like the contributor links) causes Firefox (on Windows XP) to open the link in a new tab/window.  Any idea which is right (i.e. no target or with target)?

Thanks.
Comment 1 Nigel Birch 2007-01-09 02:51:35 UTC
Created attachment 1763 [details]
Makes the year a hyperlink
Comment 2 KDF 2007-04-26 22:38:56 UTC
fixed in trunk at change 11836
and 6.5.2 at change 11837


please reopen if issues remain.
thanks, nigel
Comment 3 Nigel Birch 2007-04-27 15:59:32 UTC
Created attachment 1919 [details]
Removes target attribute from artist hyperlink
Comment 4 Nigel Birch 2007-04-27 15:59:59 UTC
The year hyperlink looks good. Thanks.

I've re-opened it because the "Artist: " hyperlink opens in a separate tab in Firefox on Vista.  I've attached a patch that I've used to remove the target attribute from the hyperlink.  I've still not yet got a Nokia 700 to test on, so I don't know whether that attribute is there for a reason (it's not on the other songinfo.html hyperlinks).  If this needs to be a separate bug then please let me know.
Comment 5 KDF 2007-04-27 17:26:47 UTC
change 11844 should cover it. thanks.
reopen again if there is anything else problematic on this template.
Comment 6 Nigel Birch 2007-04-28 04:07:32 UTC
That works fine.  Thanks.
Comment 7 Chris Owens 2007-05-22 12:10:31 UTC
Fixed in 6.5.2, which is now released and available for download at http://www.slimdevices.com/su_downloads.html

If you're still experiencing this bug, please re-open it!