Bug 4536 - player search -> all songs plays nothing
: player search -> all songs plays nothing
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 6.5.1
: All All
: P2 normal (vote)
: ---
Assigned To: Dan Sully
http://forums.slimdevices.com/showthr...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-24 09:32 UTC by KDF
Modified: 2008-12-18 11:11 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2006-11-24 09:32:45 UTC
the %findcriteria hash is built and sent to the CLI, which is expecting to build it's own find hash from a query string.  As such, the play command fails to parse the search from the player UI.

reported in the thread given above, with a possible fix (works for me, but might be a better way):

--- Slim/Control/Commands.pm.old	2006-11-22 12:51:40.425750000 -0800
+++ Slim/Control/Commands.pm	2006-11-22 12:50:28.253875000 -0800
@@ -2221,8 +2222,12 @@ sub _playlistXtracksCommand_parseSearchT
 		} else {
 
 			if ($key =~ /\.(?:name|title)search$/) {
-
-				$find{$key} = { 'like' => Slim::Utils::Text::searchStringSplit($value) };
+				
+				if (ref $value eq 'HASH') {
+					$find{$key} = $value;
+				} else {
+					$find{$key} = { 'like' => Slim::Utils::Text::searchStringSplit($value) };
+				}
 
 			} else {
 
Search -> all songs is fine from web interface
Comment 1 Chris Owens 2006-12-13 17:14:37 UTC
*** Bug 4590 has been marked as a duplicate of this bug. ***
Comment 2 Chris Owens 2006-12-13 17:16:18 UTC
Bumped severity due to end-user interest.  Assigned to Dan for his input on KDF's fix.
Comment 3 Dan Sully 2006-12-13 20:32:38 UTC
That patch is correct. Please commit
Comment 4 KDF 2006-12-13 21:15:46 UTC
committed to trunk at change 10957
6.5.1 at change 10958
Comment 5 Chris Hansen 2006-12-14 23:30:28 UTC
Version SlimServer_6.5_v2006-12-14 resolved the problem for me.  Thanks for the quick resolution!

 - Chris