Bugzilla – Bug 4531
The word "Disco" in multi-CD albums will cause displayed name to omit (Disc X of Y)
Last modified: 2008-12-18 11:12:53 UTC
I'm using iTunes to manage my music collection and edit tags. All multiple CD albums are using the Disc # of # tags. All music is encoded as MP3 with 2.3 or 2.4 version tags. I have run multiple tests against this bug by renaming various albums and then doing a rescan to see the effect in Slimsever. Double CD albums with containing the word "Disco" in their title (my tests used Disco as the first word) will fail to show "(Disc X of Y)" in Slimserver browse lists. Albums that do NOT contain that word show up correctly. Regression: Renamed a working album to include the word "Disco" - after a rescan it now failed. Renamed a previously broken album to remove the word "Disco" - after a rescan it now works. Examples: Beach House (Disc 1 of 2) Beach House (Disc 2 of 2) Disco Kandi Disco Kandi
or, is your language setting set to Portuguese, Italian or Spanish? most likely a problem with Slim::Music::Info::addDiscNumberToAlbumTitle the line: return $title if $title =~ /\b(${discWord})|(Disc)\s+\d+/i; is likely mis-detecting the word "disco" as already having the disc number in the album title.
I thought about the possibility of Slimserver having a query set to detect Disc # within the album title, so that's probably it. I have no language settings other than Default (which is English I presume). I'll keep my fingers crossed a fix for this makes it into 6.5.1 final. I have a lot of Hed Kandi albums with the word Disco in them :)
perhaps something like: return $title if $title =~ /\b((${discWord})|(Disc))\s+\d+/i; will help. I'm not 100% sure of the order of ops for regular expressions, so that MAY force "Disco" to no longer match, while "Disc #" will still match. Not sure if anything can be done for those who DO have a language setting where discWord ends up being "Disco"
Isn't all that a function of "guess tags" and if so, why is SlimServer guessing tags if the files are clearly tagged? Should clearing the patterns at Server Settings > Formatting > Guess Tags Formats disable guessing completely?
I'd rather fix the behavior Jim is talking about, if that will also fix this bug. Removing the 'Guess Tags' fields in Server Settings -> Formatting is a good trick for similar bugs. Steven, could you try to figure out if Guess Tags is interpreting 'Disco'?
Chris, I came across this bug while looking at general tagging issues. I did not realize that you asked me to look into it. Anyway, I am able to easily reproduce the behavior described. SlimServer however is recognizing the TPOS tag properly. One can verify this by looking at the Song Info for one of the "Disco" tracks. So it appears it is only the display (Disc 1 of 2) that is missing.
guess tags has nothing to do with this. whether or not there is some sort of issue with guess tags should be left for a different bug (feel free to file) In the album tag, the server will try to append the disc x of y info. However, if that info is detected as already being present, the server leaves the album title alone. this is all found in the function that I pointed to before. Note the comments: # If "disc <num>" (localized or English) is present in # the title, we assume it's already unique and don't # add the suffix. "title" in this case, refers to the ALBUM TITLE as extracted from the tags. so, I am still curious if the patch I suggested has the desired effect for someone who has a reproduced test set. thanks.
Has anyone tried this on Slimserver 7.0 yet? If not we will have a look.
I'm not able to reproduce this with 7 or 6.5.4 (13644), could you attach a sample file please?
Please reopen with an attached example if this is still happening for you, Bruno.
Created attachment 2347 [details] Screen shot of the problem happening on "Disco Kandi" Here you can see the issue still occurs with 6.5.5 nightly from November 4th on Mac OS. The two top images are for Disco Kandi and should also say (Disc 1 of 2) and (Disc 2 of 2). Below you can see two other discs showing the proper disc labeling.
Still seems to be happening on 6.5.5 nightly Nov 4th - Mac OS binary. Attached screenshot showing issue. DB manually deleted and rebuilt by SlimServer 6.5.5. I am about to attach a couple of music files as well - just need to pull them off my server.
Created attachment 2348 [details] Track 1 of Disc 1 of "Disco Kandi" release This is the first track of the first disc of an album that shows the problem. Additional attachment coming...
Created attachment 2349 [details] Track 1 of Disc 2 of "Disco Kandi" release First track of disc 2
Thanks for the samples. I was able to replicate the issue. I tested the patch I posted in comment 3, will attache the results shortly.
Created attachment 2353 [details] test results. the results of the patch. unified diff coming shortly.
Created attachment 2354 [details] slight rework of regex. as explained in comment 3, this is the unified diff version of the patch.
(In reply to comment #8) > Has anyone tried this on Slimserver 7.0 yet? If not we will have a look. > Yes, this issue is present with SC7 (14684).
patch merged into trunk at change 14725. Please test and verify.
Verified to be fixed in SC7 14725, thanks KDF.
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html