Bug 4517 – Crash on loading remote.html link

Bug 4517 - Crash on loading remote.html link

Summary:

Crash on loading remote.html link

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5.1
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Dan Sully

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-11-17 11:15 UTC by Dan Evans
Modified:	2008-12-18 11:11 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
avoid crash (863 bytes, patch) 2006-11-17 12:23 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dan Evans 2006-11-17 11:15:43 UTC

Slimserver crashes when you load this URL:  http://localhost:9000/html/remote.html

I'm running Slimserver 6.5.1 - 10622 - Windows XP - EN - cp1252

Comment 1 KDF 2006-11-17 12:05:24 UTC

Can't use an undefined value as an ARRAY reference at D:\slim\server/Slim/Web/HTTP.pm line 2268.

is that matching what you see?

Comment 2 KDF 2006-11-17 12:23:09 UTC

Created attachment 1719 [details]
avoid crash

as the crash is due to buildStatusHeaders() and the only real user of this is Salling Clicker, simplest fix is either of the two altered sections here.  It would depend on whether Salling has any need to have headers returned when @p has not been defined.

Comment 3 Chris Owens 2007-01-31 18:03:20 UTC

Did you ever check this in KDF?  I am starting to get caught up on my backlog.  If not, Dan is back in town to review it if you like.  Shall I assign it on to him?

Comment 4 KDF 2007-01-31 19:38:07 UTC

I left it here for review, since the patch given above solves the problem twice over.  One or both may be desired.
bouncing to dan.

Comment 5 Dan Sully 2007-01-31 19:40:11 UTC

sure, looks good

Comment 6 KDF 2007-01-31 19:41:28 UTC

target?

Comment 7 Dan Sully 2007-01-31 19:43:03 UTC

6.5.2

Comment 8 KDF 2007-01-31 19:49:04 UTC

fixed at change 11320 and in 6.5.2 at change 11321