Bug 4484 - ID3v2 tag using TPE1 for artist (band). eMusic or iTunes caused.
: ID3v2 tag using TPE1 for artist (band). eMusic or iTunes caused.
Status: RESOLVED WORKSFORME
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: unspecified
: All All
: P2 normal (vote)
: ---
Assigned To: Unassigned bug - please assign me!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-06 22:12 UTC by Gregory P. Smith
Modified: 2007-10-23 09:33 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gregory P. Smith 2006-11-06 22:12:27 UTC
i downloaded several albums from eMusic recently and found that they did not appear in the New Music list or even on an Artist search...  I had applied the album art to them by dragging it into the art box using itunes so the tags were rewritten at least once by that so i can't say if it was emusic or itunes that decided to write the tag this way.

odd.  so I investigated.  here's the id3v2 -l dump of the id3 tags on a couple of them.  It appears that slimserver (running a truck checkout from a few weeks after 6.5 was released) was ignoring the TPE1 tag.

id3v1 tag info for 07-Maitreya.mp3:
Title  : Maitreya                        Artist: David Parsons                 
Album  : PARSONS: Maitreya - The Future  Year: 2002, Genre: Classical (32)
Comment:                                 Track: 7
id3v2 tag info for 07-Maitreya.mp3:
TFLT (File type): MPG/3
TIT2 (Title/songname/content description): Maitreya
TPE1 (Lead performer(s)/Soloist(s)): David Parsons
TALB (Album/Movie/Show title): PARSONS: Maitreya - The Future Buddha
TPOS (Part of a set): 1/1
TCON (Content type): Classical (32)
TYER (Year): 2002
TSIZ (Size): 16989333
TRCK (Track number/Position in set): 7
USER (Terms of use):  frame
APIC (Attached picture): ()[, 0]: image/jpeg, 21145 bytes

[hahaha classical..  its buddist trance.  genre tags are silly.]

id3v1 tag info for 06-The_Way_You_Look_Tonight.mp3:
Title  : The Way You Look Tonight        Artist: William Galison & Madeleine Pe
Album  : Got You On My Mind              Year:     , Genre: Rock (17)
Comment:                                 Track: 6
id3v2 tag info for 06-The_Way_You_Look_Tonight.mp3:
TFLT (File type): MPG/3
TIT2 (Title/songname/content description): The Way You Look Tonight
TPE1 (Lead performer(s)/Soloist(s)): William Galison & Madeleine Peyroux
TALB (Album/Movie/Show title): Got You On My Mind
TPOS (Part of a set): 1/1
TCON (Content type): Rock (17)
TYER (Year): 
TSIZ (Size): 4110251
TRCK (Track number/Position in set): 6
USER (Terms of use):  frame
APIC (Attached picture): ()[, 0]: image/jpeg, 71564 bytes

and here's a patch that seems to work for me (I just guessed that TPE1 made sense to use as 'BAND'), it seems to work for me:

--- Formats/MP3.pm      (revision 9583)
+++ Formats/MP3.pm      (working copy)
@@ -78,6 +78,10 @@
        $MP3::Info::v2_to_v1_names{'TP2'}  = 'BAND';
        $MP3::Info::v2_to_v1_names{'TPE2'} = 'BAND';
 
+        # XXX-gps-20061106 eMusic is tagging their MP3s with this
+        # its "TPE1 (Lead performer(s)/Soloist(s))" according to id3v2
+       $MP3::Info::v2_to_v1_names{'TPE1'} = 'BAND';
+
        # get artwork
        $MP3::Info::v2_to_v1_names{'PIC'}  = 'PIC';
        $MP3::Info::v2_to_v1_names{'APIC'} = 'PIC';
Comment 1 Justin Fletcher 2006-11-12 11:01:00 UTC
This seems bogus to me; TPE1 is already mapped as ARTIST.
q.v. lib/MP3/Info.pm hash %v2_to_v1_names.
Remapping the tag to BAND would not help as ARTIST is already used for that tag.
Comment 2 Gregory P. Smith 2006-11-12 11:39:14 UTC
Possibly bogus.  Yes ARTIST is the correct mapping.  ignore my BAND one.  I didn't know the key names to use as there wasn't an obvious list in the file.  I didn't see the lib/MP3/Info.pm module when searching for files with tagnames at the time.

This begs the question of why me making the change helped at all before.

I'll see what happens on a new eMusic downloaded track and report back.

I've switched from trunk to 6.5 now as trunk is too unstable for me to work with at the moment.
Comment 3 Chris Owens 2007-05-25 16:59:57 UTC
Was this bug an early spotting of bug 4882?  And does the change checked in to the 6.5.3 nightlies fix it?
Comment 4 Chris Owens 2007-10-23 09:33:36 UTC
Please reopen if this is still an issue.