Bugzilla – Bug 446
Browse artwork ordering is case sensitive
Last modified: 2009-09-08 09:27:49 UTC
The order in which album art is displayed is case-sensitive based on the album title. I'd recommend making this a case-insensitive ordering.
is artwork the ONLY browse mode that comes up case sensitive? Is it the case when you use placeholders or only when you remove them, or does it occur in both? placeholder setting is in settings->additional->interface
The case-sensitive ordering only appears when browsing artwork without placeholders. Browsing artwork WITH placeholders also results in case-insensitive ordering. Browsing album names or artists uses a case-insensitive ordering.
well, at least the difference makes sense. artwork without placeholders is handled from its own list. I'm lost as to why the sorting turns out differently, however, since both lists go through the same sort routine. dean, any ideas?
Are you sure that they are going through the same sort routine? It might be worthwhile logging something there to verify.
is there any point in working this through now with the DB backend coming soon, especially since the DB backend has completely borked the artwork to the point of crashing and will obviously be totally reworked before release anyway?
Good point. Assigning to vidur to use as a test case when he's looking at the cover art support.
cool. Having just tested it out, I can't seem to find a way to reproduce this. Changing "The Long Road" album to "the long road" and then wiping cache still comes up with "The Long Road" at the right place in the sort. An example of how this is case-sensitive for you might be useful, Patrick.
Created attachment 103 [details] Screenshot of case-sensitive ordering I almost decided I couldn't reproduce it -- then I remembered to turn off placeholders. A screenshot of case-sentitive sorting is attached. The albums in the second row are: * Ziggy Stardust * Zoot Suit Riot * all songs considered * feels like home * in search of excelloung * thickfreakness
Just had a thought, and it looks like the theory panned out. It IS the same sorting routine, but its not the same info provided by the cache. Info.pm line 1673 of the main trunk needs to be changed to: push @covers, Slim::Utils::Text::ignoreCaseArticles(uc($key)); this, effectively, uses $albumCase for the sorting routine, which matches the browse by album listings
Alas, that patch causes none of the art to be displayed, although they appear to be in the right order...
er...ok, works for me. I think a wipe cache is required, thus an increment in the DBVERSION as well. oh...I diffed against the wrong thing. you need to change line 1676 to: return fixCase(Slim::Utils::Text::sortuniq_ignore_articles(@covers)); given that, cache wipe likely isn't needed after all.
Created attachment 104 [details] fix artwork info for sort preps the info to the sort routines properly so they can be sorted case-insinsitive like all the other browse modes.
Ah much better. Committed for tomorrow's nightly build. Please confirm and close if fixed.
Confirm that the recent patch fixed the issue in the nightly build.
closing.
Routine bug db maintenance; removing old versions which cause confusion. I apologize for the inconvenience.