Bug 446 - Browse artwork ordering is case sensitive
: Browse artwork ordering is case sensitive
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: PC Windows XP
: P5 minor (vote)
: ---
Assigned To: Vidur Apparao
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-07-12 19:59 UTC by patrick conant
Modified: 2009-09-08 09:27 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Screenshot of case-sensitive ordering (160.55 KB, image/jpeg)
2004-08-17 12:05 UTC, patrick conant
Details
fix artwork info for sort (266 bytes, patch)
2004-08-17 14:06 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description patrick conant 2004-07-12 19:59:46 UTC
The order in which album art is displayed is case-sensitive based on the album
title.  I'd recommend making this a case-insensitive ordering.
Comment 1 KDF 2004-08-04 16:43:22 UTC
is artwork the ONLY browse mode that comes up case sensitive?  Is it the case
when you use placeholders or only when you remove them, or does it occur in
both? placeholder setting is in settings->additional->interface
Comment 2 patrick conant 2004-08-06 07:08:49 UTC
The case-sensitive ordering only appears when browsing artwork without
placeholders.  Browsing artwork WITH placeholders also results in
case-insensitive ordering.  Browsing album names or artists uses a
case-insensitive ordering.    
Comment 3 KDF 2004-08-06 09:48:10 UTC
well, at least the difference makes sense.  artwork without placeholders is
handled from its own list.  I'm lost as to why the sorting turns out
differently, however, since both lists go through the same sort routine.  dean,
any ideas?
Comment 4 Blackketter Dean 2004-08-17 10:22:27 UTC
Are you sure that they are going through the same sort routine?  It might be worthwhile logging 
something there to verify.
Comment 5 KDF 2004-08-17 10:33:33 UTC
is there any point in working this through now with the DB backend coming soon,
especially since the DB backend has completely borked the artwork to the point
of crashing and will obviously be totally reworked before release anyway?
Comment 6 Blackketter Dean 2004-08-17 11:40:25 UTC
Good point.  Assigning to vidur to use as a test case when he's looking at the cover art support.
Comment 7 KDF 2004-08-17 11:55:06 UTC
cool.  Having just tested it out, I can't seem to find a way to reproduce this.
 Changing "The Long Road" album to "the long road" and then wiping cache still
comes up with "The Long Road" at the right place in the sort. An example of how
this is case-sensitive for you might be useful, Patrick.
Comment 8 patrick conant 2004-08-17 12:05:08 UTC
Created attachment 103 [details]
Screenshot of case-sensitive ordering

I almost decided I couldn't reproduce it -- then I remembered to turn off
placeholders.  A screenshot of case-sentitive sorting is attached.  The albums
in the second row are:
* Ziggy Stardust
* Zoot Suit Riot
* all songs considered
* feels like home
* in search of excelloung
* thickfreakness
Comment 9 KDF 2004-08-17 13:36:45 UTC
Just had a thought, and it looks like the theory panned out.  It IS the same
sorting routine, but its not the same info provided by the cache.  Info.pm line
1673 of the main trunk needs to be changed to:
push @covers, Slim::Utils::Text::ignoreCaseArticles(uc($key));

this, effectively, uses $albumCase for the sorting routine, which matches the
browse by album listings
Comment 10 Blackketter Dean 2004-08-17 13:51:25 UTC
Alas, that patch causes none of the art to be displayed, although they appear to be in the right order...
Comment 11 KDF 2004-08-17 13:58:09 UTC
er...ok, works for me.  I think a wipe cache is required, thus an increment in
the DBVERSION as well.

oh...I diffed against the wrong thing.  you need to change line 1676 to:
return fixCase(Slim::Utils::Text::sortuniq_ignore_articles(@covers));

given that, cache wipe likely isn't needed after all.
Comment 12 KDF 2004-08-17 14:06:03 UTC
Created attachment 104 [details]
fix artwork info for sort

preps the info to the sort routines properly so they can be sorted
case-insinsitive like all the other browse modes.
Comment 13 Blackketter Dean 2004-08-17 15:46:34 UTC
Ah much better.  Committed for tomorrow's nightly build.  Please confirm and close if fixed.
Comment 14 patrick conant 2004-08-18 10:00:31 UTC
Confirm that the recent patch fixed the issue in the nightly build.
Comment 15 patrick conant 2004-08-18 10:00:47 UTC
closing.
Comment 16 Chris Owens 2008-12-18 11:55:43 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.