Bug 4450 – With the Nokia770 skin, the genre hyperlink on the track info page doesn't filter by genre

Bug 4450 - With the Nokia770 skin, the genre hyperlink on the track info page doesn't filter by genre

Summary:

With the Nokia770 skin, the genre hyperlink on the track info page doesn't fi...

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Skins
Version:	6.5.1
Platform:	PC Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-10-31 07:53 UTC by Nigel Birch
Modified:	2006-11-01 01:43 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
use genre.id (805 bytes, patch) 2006-10-31 08:33 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Nigel Birch 2006-10-31 07:53:57 UTC

This is with SlimServer v6.5.1 - 10511 - Windows XP - EN - cp1252; Perl v5.8.8 MSWin32-x86-multi-thread; MySQL v5.0.22-community-nt.

With the Nokia770 skin, the track information page has a genre hyperlink.  Following this link doesn't show all artists within that genre, but instead all artists for all genres (effectively, browse artists).

For example, the track info page genre link might be:

http://servername:9000/Nokia770/browsedb.html?hierarchy=contributor,album,track&level=0&genre=3&player=playername

The genre link on the now playing page does work is:

http://servername:9000/Nokia770/browsedb.html?hierarchy=genre,contributor,album,track&level=1&genre.id=3&amp;player=playername

The track info page genre link for Default works too:

http://servername:9000/browsedb.html?hierarchy=genre,contributor,album,track&level=1&genre.id=3&player=playername

Thanks.

Comment 1 KDF 2006-10-31 08:33:51 UTC

Created attachment 1680 [details]
use genre.id

Comment 2 Ben Klaas 2006-10-31 08:55:40 UTC

does this mean you want me to do the checkin?

for trivial changes like this, I have no issue with someone else checking in a fix.

Comment 3 KDF 2006-10-31 08:57:10 UTC

proper fix committed to trunk at change 10528, and into the branch at 10529 since it's a safe fix.

Comment 4 KDF 2006-10-31 08:58:18 UTC

is ok.  The original patch wasn't correct anyway, but the original reason was that I wasn't going to have time to test before I went off to work, and unable to commmit.  I decided to take a quick test and deal with it after all.

Comment 5 KDF 2006-10-31 08:59:08 UTC

ack....and that was change 10529 and change 10530 :)

Comment 6 Nigel Birch 2006-11-01 01:43:36 UTC

Talk about quick fixing.  Looks good to me.  Thanks.