Bug 445 - setting a scroll pause of zero causes things to lock up.
: setting a scroll pause of zero causes things to lock up.
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 5.x or older
: All All
: P2 minor (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-07-12 12:55 UTC by Blackketter Dean
Modified: 2008-12-18 11:53 UTC (History)
0 users

See Also:
Category: ---


Attachments
the patch in question (554 bytes, patch)
2004-07-15 18:38 UTC, KDF
Details | Diff
proper patch for scrollrate (3.46 KB, patch)
2004-07-16 10:19 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2004-07-12 12:55:51 UTC
The check for scroll pause should be more careful.
Comment 1 KDF 2004-07-14 15:12:00 UTC
damn, 0 used to work.  That's why I changed teh settings hash from a minimum of
0.001 to allow 0.  If this locks up (and it used to way back when as well) then
the setup hash can just be back to 0.001 again.  That should be safe.
Comment 2 Blackketter Dean 2004-07-15 18:02:40 UTC
Got patch?
Comment 3 KDF 2004-07-15 18:38:36 UTC
Created attachment 71 [details]
the patch in question

this limits the scrollpause to something just above zero, and will set to that
limit if a user enters 0.  seems to work for me, but so does 0.
Comment 4 Blackketter Dean 2004-07-16 06:45:34 UTC
Well, 0 is a perfectly valid number from the user's perspective.  I forgot to include this important 
information in the original bug:

Illegal division by zero at /Users/sfrawley/Library/PreferencePanes/SlimServer.prefPane/Contents/
server/Slim/Display/Animation.pm line 624.

Does this help you reproduce?
Comment 5 KDF 2004-07-16 08:57:10 UTC
do you mean scroll RATE?
the divide on line 624 is framedelay, which shoudl be tied to rate.
Comment 6 KDF 2004-07-16 09:51:50 UTC
I tried a rate of 0 and I got the crash that you mention.  to allow the user to
enter 0, I'll make a patch that simply checks for 0.  if its 0, then we'll just
skip the whole animation routine.
Comment 7 KDF 2004-07-16 10:19:08 UTC
Created attachment 72 [details]
proper patch for scrollrate

This will simply bypass animation of any kind if scrollrate or doublerate are
set to 0. It also removes checks for animationlevel since that isn't used any
more.  note: this patch is subsequent to bug428. if you like, I'll commit
tonight and change the string to clarify that 0 = no animation.
Comment 8 KDF 2004-07-21 19:04:04 UTC
committed July 21, 2004
Comment 9 Chris Owens 2006-06-16 14:41:55 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.
Comment 10 Chris Owens 2008-12-18 11:53:02 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.