Bugzilla – Bug 4446
Current playlist page in Nokia770 skin doesn't show multiple artists
Last modified: 2008-12-18 11:11:39 UTC
This is with SlimServer v6.5.1 - 10511 - Windows XP - EN - cp1252; Perl v5.8.8 MSWin32-x86-multi-thread; MySQL v5.0.22-community-nt. The Nokia770 skin doesn't support multiple artists on it's current playlist page (third icon from left on top toolbar). For example, it displays "Night Song by Nusrat Fateh Ali Khan" rather than "Night Song by Nusrat Fateh Ali Khan, Michael Brook". This is similar to item B in comment 16 of (the sprawling) bug 3323, but is for the current playlist page instead of the now playing page. Thanks.
Created attachment 1681 [details] still needs ajax update on this change
oh, actually, this might get complicated. up to Ben whether the complexity is worth it.
Created attachment 1682 [details] potential fix This should work, but I don't have a good set of test cases here, and not enough time to really play with this until at least late evening.
I've committed to trunk (7.0a1) at change 10539. Please give this a try and if it looks ok, we can consider for 6.5.1. I'll update the changelog after that.
I'm on 6.5.1 and I'm away for a week or so from tomorrow, so I won't have time to check until when I'm back. If Ben hasn't got any multi-artist-tagged tracks, or has but hasn't had time to test by then, I'll install trunk and take a look when I'm back.
Nigel, that'd be great if you can verify the fix. I do not have any multi-artist tracks available in my collection to test.
I've given that a quick test with v7.0a1 r10540 and it seems to work fine. Not exactly related to this bug, but the song information page doesn't delimit the artists with a comma like the other pages. Let me know if it's best to create another bug for it. There's a couple of oddities, but perhaps they're specific to the (now unstable) v7.0a1 trunk. Best to mention them. 1. With one album I managed to create a duplicate album (different album.id, with no artwork, but same songs). All the other albums I tried didn't do this. The steps involved were: - search for an artist, ARTISTA, who has an album that contains songs with multiple artists - select ARTISTA - play the album that has multiple artists - search again for ARTISTA - the results show an extra album Default also does this. 2. When you play an album, the songs are added in order but playing starts with the last track. Default also does this too.
Thanks nigel. The scope of this reports would seem covered. The search problems are mentioned in other reports. As for any oddities in 7.0a1, we're currently in an "unstable" phase for 7.0 and bug reports should be held off during this time. If you are seeing problems 1 and 2 with 6.5.1, please file a bug report after checking them against existing reports. thanks. When going back to 6.5.1, it should "upgrade" fine eoung, but I'd recommend the usual uninstall re-install, saving your prefs just in case. The prefs files shouldn't be a problem, as I'm currently running both 6.5.1 and 7.0a1 off of the same prefs at home. I'll merge in the nokia skin fixes tonight.
No, v6.5.1 is fine. No downgrading needed (used a VM).
Unless I'm missing something, with v6.5.1 r10554 this isn't fixed. I've cleared Firefox's cache. I've not got time to work out whether I have the changes from r10541 on disk or not (sorry!), but the Gmane checkin for r10541 doesn't mention the changed trunk/server/HTML/EN/ajaxRequest.txt and trunk/server/HTML/Nokia770/playlist.js that r10539 mentions. Significant?
I didn't get around to merging. there will be a note here when I do.
merged into 6.5.1 at change 10571 please reopen if any problems arise.
Sorry - got ahead of myself (you!) there. That works me for - thanks.