Bugzilla – Bug 4437
Navigating unsorted lists with the number keys doesn't work
Last modified: 2009-09-08 09:13:42 UTC
The ability to jump to a specific item in unsorted lists with the number keys seems to have stopped working, e.g. try Browse -> Albums-> All Songs. The problem seems to be due to the isSorted parameter that is passed to numberScroll. I've traced this back to the test on line 867 of Slim::Buttons::BrowseDB.pm, which reads: # If this is a list of containers (e.g. albums, artists, genres) # that are not the result of a search, assume they are sorted. # sort at simple track level as well. if (($descend && !$search) || ($levels[$level] eq 'track' && !exists $find->{'album.id'} && !$search)) { This doesn't seem to be doing what's intended. The following if (($descend || !($levels[$level] eq 'track' || $levels[$level] eq 'playlistTrack')) && !$search) { seems behave sensibly for all the situations I can create.
> This doesn't seem to be doing what's intended. The following > if (($descend || !($levels[$level] eq 'track' || $levels[$level] eq > 'playlistTrack')) && !$search) { > seems behave sensibly for all the situations I can create. Checked in to trunk in r10504. To be added to 6.5 pending feedback.
Dean, please review and comment on desired behaviour for various track lists. refer to this thread as well http://forums.slimdevices.com/showthread.php?t=29171
Subject: Re: Navigating unsorted lists with the number keys doesn't work "Sorted lists" are those that are sorted alphabetically and should use the number keys as on a phone (i.e. press 2 to jump to the first item that starts with a 'B'). All others should use the number keys as numbers. Historically, this has been to press 1 to jump to the first item, 0 to jump to the last, and the other digits to jump proportionally within the list. This behavior should be encapsulated in the INPUT.list mode. (I say "historically" because I do want to move to direct number input for jumping around in unsorted lists, i.e. press 1 to jump to the first item, then press 2 to jump to the 12th. But this is a separate issue.)
I'm too poor a perl programmer to tell if this fix meets Dean's spec. Is this in the 7.0 nightlies currently, then? I will just test it there, if so.
(In reply to comment #4) > I'm too poor a perl programmer to tell if this fix meets Dean's spec. Is this > in the 7.0 nightlies currently, then? I will just test it there, if so. This will be in the 7.0 nightlies, but not in any release of 6.5.
Seems to be working. If anyone else sees this feel free to re-open.
(In reply to comment #6) > Seems to be working. If anyone else sees this feel free to re-open. Did you try 6.5? Under 6.5 (r10495), if I go 'Browse' -> 'Albums' -> 'All Songs' then use the number keys, I get completely erratic jumps. Can anyone else confirm this happens to them too?
Just to confirm, still a problem under 6.5.1 r10724
If this is fixed, we should probably look at porting this over to 6.5.x after all this time, but too late for 6.5.2 can be punted or marked as fixed if trunk is the only place we want it.
fixed in 6.5.3 at change 12104. Not something we could fold into INPUT.List in this case. INPUT.List does handle number navigation automatically, but it still must be told whether the list is sorted or not, and what kind. INPUT.List just see a list and knows nothing about it.