Bug 4408 - MoodLogic errors with MoodLogic disabled
: MoodLogic errors with MoodLogic disabled
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Plugins
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-22 04:31 UTC by Jim McAtee
Modified: 2008-12-18 11:12 UTC (History)
0 users

See Also:
Category: ---


Attachments
possible fix (458 bytes, patch)
2006-10-23 14:07 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2006-10-22 04:31:20 UTC
After change 10439, I'm seeing this in the new log, even though the MoodLogic plugin is disabled:

[05:26:17.9121] Plugins::MoodLogic::Common::OLEError (12) Error: Win32::OLE(0.1702) error 0x800401f3: "Invalid class string"
[05:26:17.9127] Plugins::MoodLogic::Common::OLEError (12) Error: Win32::OLE(0.1702) error 0x800401f3: "Invalid class string"
[05:26:17.9131] Plugins::MoodLogic::Plugin::initPlugin (118) Error: Could not find MoodLogic mixer component.
Comment 1 KDF 2006-10-22 14:38:34 UTC
if you've got debug level set to error, then you should see these, unless the plugin is disabled.  however, given your mention of pref issues in other bug reports, I suspect that this is all part of the same problem. 
Comment 2 KDF 2006-10-23 13:53:01 UTC
nix that.  it seems that the plugin loader checks the plugins enabled() function.  If this calls initPlugin, then the plugin is initialised regardless of being disabled.  this would affect musicmagic as well.
Comment 3 KDF 2006-10-23 14:07:54 UTC
Created attachment 1663 [details]
possible fix

bypass any plugin loading functions when a plugin is disabled.
Comment 4 Jim McAtee 2006-10-23 14:45:47 UTC
Change $item to $plugin and it works.
Comment 5 Jim McAtee 2006-10-23 15:42:16 UTC
Whoops. Closed prematurely. Will wait until the patch is committed.
Comment 6 KDF 2006-10-23 18:27:59 UTC
fixed at change 10462.
Comment 7 Chris Owens 2008-03-07 09:03:58 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.