Bug 4375 – Lyrics do not display with line spacing/breaks correctly (part II)

Bug 4375 - Lyrics do not display with line spacing/breaks correctly (part II)

Summary:

Lyrics do not display with line spacing/breaks correctly (part II)

Status:	RESOLVED DUPLICATE of bug 3044

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.5.1
Platform:	PC Debian Linux

Importance:	P2 minor (vote)
Target Milestone:	---
Assigned To:	Chris Owens

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2006-10-15 06:59 UTC by Markus Schiegl
Modified:	2006-10-15 11:22 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Markus Schiegl 2006-10-15 06:59:47 UTC

Sequal to https://bugs-archive.lyrion.org/show_bug.cgi?id=3044:

i had the same problem (and solution) as "blueweiser" in
http://forums.slimdevices.com/showthread.php?t=28160

this patch against latest songinfo.html from 6.5(.1) branch worked for me:

--- songinfo.html?rev=10137     2006-10-15 15:28:57.000000000 +0200
+++ songinfo.html       2006-10-15 15:30:18.000000000 +0200
@@ -115,7 +115,7 @@
 
                [% IF itemobj.lyrics %] 
                        <li><div class="songInfoTitle">[% "LYRICS" | string; "COLON" | string %]</div>
-                               <div class="songInfoText">[% itemobj.lyrics | html | html_para %]</div>
+                               <div class="songInfoText">[% itemobj.lyrics | html_line_break | html_para %]</div>
                        </li>
                [% END %]

reading through the different bug reports regarding lyrics formatting this seems a bit like a mine field. I don't know what adverse effects this patch may have. Nevertheless thanks for considering - credit goes to Grotus :-)

Comment 1 KDF 2006-10-15 11:22:26 UTC

I'm going to dupe this with 3044, since it is really the same bug. 
patching shortly.

*** This bug has been marked as a duplicate of 3044 ***