Bugzilla – Bug 4374
Knob displaying last item twice+ after deleting playlist entry
Last modified: 2009-01-14 10:13:24 UTC
After removing one or more item(s) from the Now Playing list by pressing ADD on the remote or the front panel the Knob will not stop at the last entry but continue to display for every removed item: - go to Now Playing - remove one or more items -> x of y is updated correctly - to to item y using the Knob - turn the Knob further down -> it will repeat displaying the last item and "y of y" for the number of items removed, before it hits the end of the list This is with fw 21 (not available from the fw list on the bug form), using the 6.5.1 2006-10-06 nightly build.
try adding: $client->updateKnob(); to Slim::Player::Playlist::refreshPlaylist();
> $client->updateKnob(); Didn't help.
Does $client->updateKnob(1) help?
(In reply to comment #3) > Does $client->updateKnob(1) help? Yep, that does the trick.
Created attachment 1644 [details] complete patch? Would this patch be ok?
shoudn't need the second part, since the client is covered in the $everyclient loop. I don't believe that the isa(transporter) test is needed either as there is a dummy funciton in Slim::Player::Client
You mean this should do? Index: Playlist.pm =================================================================== --- Playlist.pm (revision 10354) +++ Playlist.pm (working copy) @@ -335,6 +335,7 @@ for my $everybuddy ($client, Slim::Player::Sync::syncedWith($client)) { if ($everybuddy->isPlayer()) { Slim::Buttons::Playlist::jump($everybuddy,$index); + $everybuddy->updateKnob(1); } }
Michael, see campfire - I think this fix would create more knob traffic than desirable. Could you do a --d_ui and see whether knob updates are already sent when you delete items from the list [they appear to be for me?]
fixed in 6.5.1 at change 10428. please update and verify. the fixed needed was already in trunk, so no changes were made there aside from the changelog.
Closing fixed bugs