Bug 4364 - Pandora dual-screen text display sync issues
: Pandora dual-screen text display sync issues
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Pandora
: unspecified
: PC Windows XP
: P2 minor (vote)
: Future
Assigned To: Andy Grundman
:
Depends on: 4009
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-13 14:29 UTC by Chris Owens
Modified: 2008-12-15 13:05 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Owens 2006-10-13 14:29:09 UTC
I haven't filed enough SN bugs lately.  :)

When I'm listening to Pandora on a Transporter, I've decided I like the title + progress bar + time remaining on the left screen, and the spectrograph with channel name overlay on the right screen, because I thrive on information overload.  We'll call this 'state 1'.

In this state, if I hit the knob button it shifts the display around slightly.  The left screen of course shows the "I like this song" menu, and the right one turns into the title overlaid with the spectrograph.  That part is good, it makes sense and it looks nice.  Let's call this 'state 2'.

Now, from state 2 I select 'I don't like this song'.  Pandora starts playing a new track and the left screen switches to the message 'Sorry, we won't play that song again'.  This message is shown for a few seconds so the user can read it, which is good.  HOWEVER during that few seconds, the right screen continues to show the information for the song that I just killed.  After the few seconds is over and the Transporter returns to state 1, the right screen is updated to show the new song info.

It seems like the new song info should appear in the appropriate place as soon as the new song begins playing.
Comment 1 Andy Grundman 2006-10-13 14:31:51 UTC
The issue is the second screen doesn't update on setCurrentTitle.  Any ideas Triode?
Comment 2 Chris Owens 2006-10-13 14:57:57 UTC
Since I was so verbose in the initial report, I'll clarify the last sentence of the second-to-last paragraph.  It should read: After the few seconds is over, the Transporter returns to state 1 and the song display (now on the left screen) is correct.
Comment 3 Adrian Smith 2006-10-14 03:02:19 UTC
Andy - is the: "Sorry, we won't play that song again" message displayed using showBriefly?

If so this is really a consequence of bug 4009 - showBriefly on screen1 will block periodic updates to the second screen.  I've been considering the best way round this, but haven't written any code yet as I wanted to think through the impact of the changes necessary.  I'll get back to looking at this.

If the error message was displayed via update [i.e via the normal lines function for the mode], then I suspect you would not see this.
Comment 4 Andy Grundman 2006-10-14 07:44:57 UTC
Yes those messages use showBriefly.
Comment 5 Adrian Smith 2006-10-14 14:10:04 UTC
Andy - do you use the block param to showBriely for them?
Comment 6 Andy Grundman 2006-10-14 14:24:58 UTC
Yeah, the code looks like this:

		$client->showBriefly( {
			line1 => $line1,
			line2 => $line2,
		},
		{
			block    => 1,
			scroll   => 1,
			callback => sub {
				# After displaying the rating confirmation message, we want to go back
				# to the Now Playing screen, not leave users sitting in the menu
				if ( blessed $client ) {
					Slim::Buttons::Common::pushMode( $client, 'playlist' );
				}
			},
		} );
Comment 7 Chris Owens 2006-10-25 17:13:49 UTC
You can't fool me with marking this as 'future'.  It seems to be fixed as of right now...
Comment 8 Adrian Smith 2006-10-26 11:11:58 UTC
Yep - if Andy has included the trunk changes for 4009 it should be fixed now!
Comment 9 Andy Grundman 2006-10-26 11:12:46 UTC
Yep it's fixed.
Comment 10 James Richardson 2008-12-15 13:05:03 UTC
This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.