Bug 4352 - Server crashes on second page of search
: Server crashes on second page of search
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 6.5.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Chris Owens
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-11 23:36 UTC by Ben Strulo
Modified: 2006-10-12 20:54 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
proposed fix (547 bytes, patch)
2006-10-12 00:15 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Strulo 2006-10-11 23:36:22 UTC
Choose a simple search which returns many results (mine returns 2 artists 2 albums and 52 song titles).
The search results page contains a link for the page "2".  Clicking the "2" causes the server to crash.

Crash message is

Carp::Clan::__ANON__(): rows attribute must be positive if present at J:\Program Files\SlimServer\server/Slim/Schema/Storage.pm line 30


The problem was present in 6.5.0 release.  I upgraded to latest nightly: SlimServer Version: 6.5.1 - 10284
and the problem persists.

I initially experienced the problem in the handheld interface but it is also present in the fishbone one and perhaps others.

I have logged the problem as database but obviously it could be an interface issue, or something else.
Comment 1 KDF 2006-10-12 00:15:42 UTC
Created attachment 1641 [details]
proposed fix

a minor typo in the $offset line, but the fix is to add the offset to the limit so that is is always greater than the $start by the number of items per page.
Comment 2 Ben Strulo 2006-10-12 12:58:41 UTC
I made these changes in the file and it didn't fix it for me.

Did I need to do a make (some compilation?)

Maybe I should just wait for the next nightly :-)
Comment 3 KDF 2006-10-12 13:05:20 UTC
running on winxp, you'd need a build, or install activePerl and run slimserver.pl instead of the service.
it won't be in a 6.5.1 nightly (if at all) until reviewed and approved.  
Comment 4 KDF 2006-10-12 20:54:54 UTC
fixed in trunk at change 10306 and 6.5.1 in change 10307.
please update to the latest nightly and reopen if there are any issues.