Bugzilla – Bug 4333
Mixerlinks taken out of browse years
Last modified: 2006-10-21 14:08:48 UTC
removed in change 8679. from the comment on that change, it is not clear why the code was removed. presumably it was accidental: Description: Make Years be their own object, to remove special cases. diff to add back in: Index: Slim/Schema/Year.pm ================================================== ================= --- Slim/Schema/Year.pm (revision 10266) +++ Slim/Schema/Year.pm (working copy) @@ -46,6 +46,15 @@ my ($self, $form, $descend, $sort) = @_; $form->{'text'} = $self->name; + + my $Imports = Slim::Music::Import->importers; + + for my $mixer (keys %{$Imports}) { + + if (defined $Imports->{$mixer}->{'mixerlink'}) { + &{$Imports->{$mixer}->{'mixerlink'}}($self, $form, $descend); + } + } } 1; If there is still time, it might be nice to get this back into 6.5.1
Created attachment 1634 [details] proposed patch add back the mixerlinks under browse year. Also add src_mix params for the pwdlist, and a couple of trivial fixes for other src_mix cases, and removal of extra &'s in mixerlink query url.
I would be concerned about adding this patch at this late date, but perhaps Dan has another opinion.
added into trunk at change 10309. at least this way it will see more open use.
dan, is this something we can put back into 6.5.1? or shoudl I close this as something that is only going to be back when it comes to 7.0?
Since the plugin has been fixed, I'm ok with putting it back.
in 6.5.1 at change 10434, with changelog note moved from 7 to 6.5